[prev in list] [next in list] [prev in thread] [next in thread] 

List:       tapestry-dev
Subject:    [jira] [Commented] (TAP5-2546) Parallel class loading
From:       "Hudson (JIRA)" <jira () apache ! org>
Date:       2017-03-31 6:50:41
Message-ID: JIRA.12969738.1463209837000.172901.1490943041798 () Atlassian ! JIRA
[Download RAW message or body]


    [ https://issues.apache.org/jira/browse/TAP5-2546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15950411#comment-15950411 \
] 

Hudson commented on TAP5-2546:
------------------------------

FAILURE: Integrated in Jenkins build tapestry-trunk-freestyle #1615 (See \
                [https://builds.apache.org/job/tapestry-trunk-freestyle/1615/])
TAP5-2546: use class loading lock for synchronization This does not (jochen.kemnade: \
                rev 77a2cc3769450d4a90004b1d72ce75c156c6a711)
* (edit) plastic/src/main/java/org/apache/tapestry5/internal/plastic/PlasticClassLoader.java
                
TAP5-2546: register PlasticClassLoader as parallel capable (jochen.kemnade: rev \
                627df8511604bc969af4e59ed34fb9578ed1586d)
* (edit) plastic/src/main/java/org/apache/tapestry5/internal/plastic/PlasticClassLoader.java



> Parallel class loading
> ----------------------
> 
> Key: TAP5-2546
> URL: https://issues.apache.org/jira/browse/TAP5-2546
> Project: Tapestry 5
> Issue Type: Sub-task
> Components: plastic
> Reporter: Michael Mikhulya
> Assignee: Jochen Kemnade
> Fix For: 5.5.0
> 
> 
> I would like to improve page loading time by improving its concurrent execution.
> Here is a first patch related to it: TAP5-2545
> Now the worst place from lock contention point of view is synchronization on \
> {{PlasticClassLoader}}. Actually there are two kind of synchronization: \
> {{synchronized}} methods in {{PlasticClassLoader}} and {{synchronized (loader)}} \
> sections in {{PlasticClassPool}}. Recently most class loaders added support for \
> parallel class loading: https://bugs.eclipse.org/bugs/show_bug.cgi?id=464442
> https://bz.apache.org/bugzilla/show_bug.cgi?id=57681
> If we would like to split global lock, then we can use following trick for it.
> We can substitute code like this:
> {code:title=PlasticClassLoader.java}
> public synchronized Class<?> defineClassWithBytecode(String className, byte[] \
> bytecode) {
> return defineClass(className, bytecode, 0, bytecode.length);
> }
> {code}
> with following one:
> {code:java}
> public Class<?> defineClassWithBytecode(String className, byte[] bytecode)
> {
> synchronized (className.intern())
> {
> return defineClass(className, bytecode, 0, bytecode.length);
> }
> }
> {code}
> It is just an idea to quickly check solution.
> Can anybody check and discuss idea? Or even better to fix issue. :-)
> I'm not an expert in concurrency and afraid making changes in such a critical place \
> at least before somebody reviewed my idea. So any feedback would be appreciated. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[prev in list] [next in list] [prev in thread] [next in thread]