[prev in list] [next in list] [prev in thread] [next in thread] 

List:       tapestry-dev
Subject:    [jira] [Commented] (TAP5-2551) module t5/core/messages and default locale
From:       "Jochen Kemnade (JIRA)" <jira () apache ! org>
Date:       2017-03-29 8:05:41
Message-ID: JIRA.12972452.1464110474000.151956.1490774741563 () Atlassian ! JIRA
[Download RAW message or body]


    [ https://issues.apache.org/jira/browse/TAP5-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946699#comment-15946699 \
] 

Jochen Kemnade commented on TAP5-2551:
--------------------------------------

bq. But in some situations this code exectutes before another code that sets the \
Locale through LocalizationSetter I think that we need to figure out why that \
happens. I tried to reproduce this behavior but haven't succeeded so far.

> module t5/core/messages and default locale
> ------------------------------------------
> 
> Key: TAP5-2551
> URL: https://issues.apache.org/jira/browse/TAP5-2551
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.4, 5.4.1
> Reporter: Carlos Montero Canabal
> Labels: locale, messages
> Attachments: image.jpeg
> 
> 
> In the js for module messages:
> var locale;
> locale = document.documentElement.getAttribute("data-locale") || "en";
> define("t5/core/messages", ["./messages/" + locale, ....
> If my webapp is not configured for locale "en" requirejs returns a 404 not found \
> error because the "t5/core/messages/en" doesn īt exist and the page doesn īt load \
> (it only shows the mask meanwhile all modules are loading).  You will put the first \
> locale configured into SymbolConstants.SUPPORTED_LOCALES as the documentation says. \
> In fact, there is another bug but I don't found the point of code where it occurs. \
> Yesterday a Google Chrome update force my locale to en_US (i'm spanish and my \
> locales is es or es_ES) and when I enter on my webpage who load the messages \
> module, the data-locale attribute was "en_US", but my webapp only have configured \
> "es". I think there is a missing check between browser locale and locales \
> supported. I have a webapp store and today any user can buy because the checkout \
> page (with forms that require messages module) doesn īt load. I fix it with a \
> workaound (threadLocale.setLocale(new Locale("es")) in the activate method of \
> pages), but I think that it's a important bug because many websites as mine can be \
> off. 
> UPDATED: As I comment at the bottom, It was a fortuity that my Chrome locale was \
> the same that the Java VM locale (en_US), so the main bug is in the default locale \
> who returns ThreadLocaleImpl meanwhile LocalizationSetter is not called.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[prev in list] [next in list] [prev in thread] [next in thread]