[prev in list] [next in list] [prev in thread] [next in thread] 

List:       tapestry-dev
Subject:    Re: Tapestry 5.4 and java8
From:       Kalle Korhonen <kalle.o.korhonen () gmail ! com>
Date:       2014-03-26 16:15:25
Message-ID: CA+=EWnCxP-GiPbm29fevVuWYb4b7m_rUUzAkByX=Yv9-vd5AhA () mail ! gmail ! com
[Download RAW message or body]


On Wed, Mar 26, 2014 at 8:04 AM, Howard Lewis Ship <hlship@gmail.com> wrote:

> Another option to accesspritected member is to add a new class is same
> package withstatic  shim method
>

Of course. But at that point, you could just as well fix it in Plastic and
access it properly, by instantiating the class first (it has a
corresponding, non-static public operation).

Kalle


> On Saturday, March 22, 2014, Kalle Korhonen <kalle.o.korhonen@gmail.com>
> wrote:
>
> > On Sat, Mar 22, 2014 at 8:47 AM, Bob Harner <bobharner@gmail.com
> <javascript:;>>
> > wrote:
> >
> > > True, but that particular visibility change will need to be repeated
> each
> > > time ASM is upgraded in Tapestry, if I'm understanding what you did.
> > >
> >
> > You cannot know that. It depends solely on how ASM is changed.
> >
> > Kalle
> >
> >
> >
> > > On Mar 22, 2014 11:13 AM, "Kalle Korhonen" <kalle.o.korhonen@gmail.com
> >
> > > wrote:
> > >
> > > > On Sat, Mar 22, 2014 at 3:56 AM, Bob Harner <bobharner@gmail.com>
> > wrote:
> > > >
> > > > > Kalle,
> > > > > I guess there would be another step?
> > > > > 7) "Also made a single change
> > > > > to ASM source, promoted visibility of AnnotationNode.accept from
> > > package
> > > > > private to public so I didn't have change to plastic (to
> instantiate
> > > > > AnnotationNode)" ... Or is that what you meant by step 6?
> > > > >
> > > >
> > > > Yes, that's what's included in the step 6. Really, we can't describe
> > > exact
> > > > steps to incorporate codebase with unknown future changes.
> > > >
> > > > Kalle
> > > >
> > > >
> > > >
> > > > > On Mar 21, 2014 12:40 PM, "Kalle Korhonen" <
> > kalle.o.korhonen@gmail.com
> > > >
> > > > > wrote:
> > > > >
> > > > > > On Fri, Mar 21, 2014 at 3:57 AM, Bob Harner <bobharner@gmail.com
> >
> > > > wrote:
> > > > > >
> > > > > > > Kalle, can you list the steps you went through to do this? I'd
> > like
> > > > to
> > > > > > > document the process, since it isn't simply a matter of
> > > incrementing
> > > > > the
> > > > > > > version of a dependency.
> > > > > > >
> > > > > >
> > > > > > Sure. It was very simple actually:
> > > > > > 1) Have plastic module open on your favorite IDE
> > > > > > 2) Download an asm source release from
> > > > > http://forge.ow2.org/projects/asm/
> > > > > > 3) untar the asm source, move the source tree (starting from
> "org")
> > > > next
> > > > > to
> > > > > > plastic/src/external/java
> > > > > > 4) delete the existing package
> > > > > "org.apache.tapestry5.internal.plastic.asm"
> > > > > > 5) use the IDE to rename the "org.objectweb.asm" package to
> > > > > > "org.apache.tapestry5.internal.plastic.asm"
> > > > > > 6) fix compilation errors
> > > > > >
> > > > > > Naturally, your IDE needs to be smart enough to refactor the
> > package
> > > > > names
> > > > > > in the class files accordingly.
> > > > > >
> > > > > > Kalle
> > > > > >
> > > > > >
> > > > > >
> > > > > > > On Mar 20, 2014 4:16 PM, "Kalle Korhonen" <
> > > > kalle.o.korhonen@gmail.com>
> > > > > > > wrote:
> > > > > > >
> > > > > > > > Sure, no problem. We still need it released but that might
> have
> > > to
> > > > > wait
> > > > > > > > till 5.4 GA release. Easy enough for those who need it to
> build
> > > it
> > > > > > > > themselves though.
> > > > > > > >
> > > > > > > > Kalle
> > > > > > > >
> > > > > > > >
> > > > > > > > On Thu, Mar 20, 2014 at 1:03 PM, Joachim Van der Auwera <
> > > > > > lists@progs.be
> > > > > > > > >wrote:
> > > > > > > >
> > > > > > > > > THanks Kalle for doing this.
> > > > > > > > >
> > > > > > > > > Kind regards,
> > > > > > > > > Joachim
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > On 03/18/2014 08:32 PM, Joachim Van der Auwera wrote:
> > > > > > > > >
> > > > > > > > >> Java8 is now officially available.
> > > > > > > > >> ASM 5.0 has also been released (see
> > > http://forge.ow2.org/forum/
> > > > > > > > >> forum.php?forum_id=2302)
> > > > > > > > >>
> > > > > > > > >
>
>
>
> --
> Howard M. Lewis Ship
>
> Creator of Apache Tapestry
>
> The source for Tapestry training, mentoring and support. Contact me to
> learn how I can get you up and productive in Tapestry fast!
>
> (971) 678-5210
> http://howardlewisship.com
>


[prev in list] [next in list] [prev in thread] [next in thread]