[prev in list] [next in list] [prev in thread] [next in thread] 

List:       tapestry-dev
Subject:    DO NOT REPLY [Bug 22694]  -
From:       bugzilla () apache ! org
Date:       2003-08-25 16:58:11
[Download RAW message or body]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22694>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22694

Add url parameter to Shell component





------- Additional Comments From psynix@t-online.de  2003-08-25 16:58 -------
Probably best to call the parameter "uri" instead of "url".

Here's a no-biggie patch:

Index: Shell.java
===================================================================
RCS file:
/home/cvspublic/jakarta-tapestry/framework/src/org/apache/tapestry/html/Shell.java,v
retrieving revision 1.6
diff -u -r1.6 Shell.java
--- Shell.java	1 Jul 2003 20:49:34 -0000	1.6
+++ Shell.java	25 Aug 2003 16:54:18 -0000
@@ -100,11 +100,14 @@
             startTime = System.currentTimeMillis();
 
             String DTD = getDTD();
+            String URI = getURI();
 
             if (!StringUtils.isEmpty(DTD))
             {
                 writer.printRaw("<!DOCTYPE HTML PUBLIC \"");
                 writer.printRaw(DTD);
+                writer.printRaw("\" \"");
+                writer.printRaw(URI);
                 writer.printRaw("\">");
                 writer.println();
             }
@@ -231,6 +234,10 @@
     public abstract String getDTD();
 
     public abstract void setDTD(String DTD);
+    
+    public abstract String getURI();
+    
+  	public abstract void setURI(String URI);
 
     public abstract Object getStylesheets();
 
@@ -243,7 +250,8 @@
      */
     protected void finishLoad()
     {
-        setDTD("-//W3C//DTD HTML 4.0 Transitional//EN");
+        setDTD("-//W3C//DTD HTML 4.01 Transitional//EN");
+        setURI("http://www.w3.org/TR/html4/loose.dtd");
     }
 
 }

Index: Shell.jwc
===================================================================
RCS file:
/home/cvspublic/jakarta-tapestry/framework/src/org/apache/tapestry/html/Shell.jwc,v
retrieving revision 1.4
diff -u -r1.4 Shell.jwc
--- Shell.jwc	29 Jun 2003 18:05:41 -0000	1.4
+++ Shell.jwc	25 Aug 2003 16:54:18 -0000
@@ -41,6 +41,14 @@
     </description>
   </parameter>
   
+  <parameter name="URI"
+    type="java.lang.String"
+    direction="in">
+    <description>
+    Used to specify the DOCTYPE URI of the response page.
+    </description>
+  </parameter>
+  
   <parameter 
   	name="renderContentType" 
   	type="boolean"

[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic