[prev in list] [next in list] [prev in thread] [next in thread]
List: taglib-devel
Subject: Re: String::detach() not thread-safe?
From: Kyle <gonemad () gmail ! com>
Date: 2015-05-14 10:33:46
Message-ID: CADALLbBmmpX-7EtGJOdcjKQRf=cJ3kWLP1D6jhOcoYa8P-f10Q () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Check back on the mailing list to 10/12/2013 and i made a related post
You need to build with TAGLIB_ATOMIC_GCC and that should fix it
On May 14, 2015 2:32 AM, "Tsuda Kageyu" <tsuda.kageyu@gmail.com> wrote:
> Hmm, I was wrong. PR #493 won't fix your problem, PR #493 will fix only
> ByteVector...
>
> 2015-05-09 23:30 GMT+09:00 Tsuda Kageyu <tsuda.kageyu@gmail.com>:
>
>> Hi Kevin,
>>
>> I made another PR #493 that will fix your problem as well. But it hasn't
>> been reviewed yet.
>>
>> Cheers,
>> Kageyu
>>
>> 2015-05-09 22:05 GMT+09:00 Kevin Andr=C3=A9 <hyperquantum@gmail.com>:
>>
>>> Hi,
>>>
>>> On Sat, Nov 15, 2014 at 2:03 PM, Tsuda Kageyu <tsuda.kageyu@gmail.com>
>>> wrote:
>>> > I suggested a pull request that will fix it:
>>> > https://github.com/taglib/taglib/pull/433
>>>
>>> It seems the merge request was denied because the changes were
>>> considered too complicated. So I need another solution.
>>>
>>> I think only the static members need to be fixed. Like String::null.
>>> Either the static members need to be made thread-safe, or they will
>>> need to be removed.
>>> Or I will need to create a taglib worker thread in my application,
>>> with a queue to handle all tasks that need taglib. That would
>>> complicate things a lot, I guess.
>>>
>>>
>>> Regards,
>>>
>>> Kevin
>>> _______________________________________________
>>> taglib-devel mailing list
>>> taglib-devel@kde.org
>>> https://mail.kde.org/mailman/listinfo/taglib-devel
>>>
>>
>>
>
> _______________________________________________
> taglib-devel mailing list
> taglib-devel@kde.org
> https://mail.kde.org/mailman/listinfo/taglib-devel
>
>
[Attachment #5 (text/html)]
<p dir="ltr">Check back on the mailing list to 10/12/2013 and i made a related \
post</p> <p dir="ltr">You need to build with TAGLIB_ATOMIC_GCC and that should fix \
it</p> <div class="gmail_quote">On May 14, 2015 2:32 AM, "Tsuda Kageyu" \
<<a href="mailto:tsuda.kageyu@gmail.com">tsuda.kageyu@gmail.com</a>> wrote:<br \
type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hmm, I was wrong. PR \
#493 won't fix your problem, PR #493 will fix only ByteVector...</div><div \
class="gmail_extra"><br><div class="gmail_quote">2015-05-09 23:30 GMT+09:00 Tsuda \
Kageyu <span dir="ltr"><<a href="mailto:tsuda.kageyu@gmail.com" \
target="_blank">tsuda.kageyu@gmail.com</a>></span>:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr">Hi Kevin,<div><br></div><div>I made another PR \
#493 that will fix your problem as well. But it hasn't been reviewed \
yet.</div><div><br></div><div>Cheers,</div><div>Kageyu</div></div><div><div><div \
class="gmail_extra"><br><div class="gmail_quote">2015-05-09 22:05 GMT+09:00 Kevin \
André <span dir="ltr"><<a href="mailto:hyperquantum@gmail.com" \
target="_blank">hyperquantum@gmail.com</a>></span>:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hi,<br> <span><br>
On Sat, Nov 15, 2014 at 2:03 PM, Tsuda Kageyu <<a \
href="mailto:tsuda.kageyu@gmail.com" target="_blank">tsuda.kageyu@gmail.com</a>> \
wrote:<br> > I suggested a pull request that will fix it:<br>
> <a href="https://github.com/taglib/taglib/pull/433" \
target="_blank">https://github.com/taglib/taglib/pull/433</a><br> <br>
</span>It seems the merge request was denied because the changes were<br>
considered too complicated. So I need another solution.<br>
<br>
I think only the static members need to be fixed. Like String::null.<br>
Either the static members need to be made thread-safe, or they will<br>
need to be removed.<br>
Or I will need to create a taglib worker thread in my application,<br>
with a queue to handle all tasks that need taglib. That would<br>
complicate things a lot, I guess.<br>
<br>
<br>
Regards,<br>
<br>
Kevin<br>
<div><div>_______________________________________________<br>
taglib-devel mailing list<br>
<a href="mailto:taglib-devel@kde.org" target="_blank">taglib-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/taglib-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/taglib-devel</a><br> \
</div></div></blockquote></div><br></div> </div></div></blockquote></div><br></div>
<br>_______________________________________________<br>
taglib-devel mailing list<br>
<a href="mailto:taglib-devel@kde.org">taglib-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/taglib-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/taglib-devel</a><br> \
<br></blockquote></div>
[Attachment #6 (text/plain)]
_______________________________________________
taglib-devel mailing list
taglib-devel@kde.org
https://mail.kde.org/mailman/listinfo/taglib-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic