[prev in list] [next in list] [prev in thread] [next in thread] 

List:       taglib-devel
Subject:    Re: Is ID3v2::FrameFactory really utilized?
From:       Scott Wheeler <wheeler () kde ! org>
Date:       2013-09-12 0:51:52
Message-ID: A8B9E3D3-18D4-4141-9B3A-13E782CD9C6E () kde ! org
[Download RAW message or body]

On Sep 11, 2013, at 4:17 PM, Tsuda Kageyu <tsuda.kageyu@gmail.com> wrote:

> Hi, I have a question for the TagLib users. I want to know is there 
> someone who creates your own version of ID3v2::FrameFactory.
> 
> Currently, TagLib allows you to interpret the frames in a ID3v2 tag in 
> your preferred way by subclassing ID3v2::FrameFactory class (but it only 
> affects MPEG files). However, I found that it's difficult to implement 
> my own FrameFactory because user defined classes can't access the nested 
> class ID3v2::Frame::Header. So I have a doubt that it is really utilized.
> 
> If there is someone using it, we'd better make changes so that it can 
> affect all the file formats which support ID3v2 tag. Otherwise, we can 
> remove it.

It's never actually been possible to use it properly because of a bug in the initial \
version:  ID3v2FrameFactory::createFrame() wasn't made virtual.  We've been stuck \
with that bug for binary compatibility reasons for the last 10 years.

In theory I still like the idea -- TagLib doesn't implement the full ID3v2 standard \
and subclassing ID3v2FrameFactory would in theory make it possible for users of the \
library to implement frame types not supported by TagLib itself without forking \
TagLib.

-Scott
_______________________________________________
taglib-devel mailing list
taglib-devel@kde.org
https://mail.kde.org/mailman/listinfo/taglib-devel


[prev in list] [next in list] [prev in thread] [next in thread]