[prev in list] [next in list] [prev in thread] [next in thread] 

List:       taglib-devel
Subject:    Re: CHAP frames support
From:       Lukáš Lalinský <lalinsky () gmail ! com>
Date:       2013-04-15 7:18:57
Message-ID: CAGUtLj8GOnU=uK-+TzNbrLK1KbQP45gegp7dHbfsFUwE_si5bA () mail ! gmail ! com
[Download RAW message or body]

Hi Lukas,

This seems to be just two additional ID3 frames, so that shouldn't be
too hard to implement.

The main implementation of the two frames should go to do the
taglib/mpeg/id3v2/frames/ directory. There should be also some tests
in tests/test_id3v2.cpp for parsing and rendering of the frame data.

When you have the frame reading code implemented, you just need to add
them to mpeg/id3v2/id3v2framefactory.cpp and I think that should be
it.

The best way to submit the patch is a pull request at GitHub (so you
fork the repository at GitHub, create a new branch locally, work on
that branch, push the branch to your fork, submit a pull request
against the master branch).

Lukas

On Sun, Apr 14, 2013 at 9:50 AM, Luk=E1=B9 Krej=E8=ED <krejclu6@fel.cvut.cz=
> wrote:
> Also, because I'm new to taglib, I would appreciate any help. And by the
> way, how can I submit patch, when I'll finish it? Thanks for answers.
>
> Best regards,
> Lukas Krejci
>
> Od: Luk=E1=B9 Krej=E8=ED
> Odesl=E1no: sobota, 13. dubna 2013 23:08
> Komu: taglib-devel@kde.org
>
> Hi, I'd like to contribute on taglib by adding support for chapter frames
> (https://github.com/taglib/taglib/issues/81). Is it possible?
>
> Best regards,
> Lukas Krejci
>
>
> _______________________________________________
> taglib-devel mailing list
> taglib-devel@kde.org
> https://mail.kde.org/mailman/listinfo/taglib-devel
>
_______________________________________________
taglib-devel mailing list
taglib-devel@kde.org
https://mail.kde.org/mailman/listinfo/taglib-devel
[prev in list] [next in list] [prev in thread] [next in thread]