'Re: [PATCH] virtual *property* methods'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       taglib-devel
Subject:    Re: [PATCH] virtual *property* methods
From:       Luká¹ Lalinskı <lalinsky () gmail ! com>
Date:       2013-02-06 14:39:09
Message-ID: CAGUtLj9QyzYhKEYzdGeo9aDWUjwfkxcTXkOdbT-Ny1bDQJxtxg () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

Hi Sebastian,

Thank you for the patch, but I'm afraid this is duplicate work that has
already been done.

These methods are not virtual in the "master" branch for ABI compatibility
reasons. I think that all of them are already fixed in the "taglib2" branch=
:

https://github.com/taglib/taglib/tree/taglib2

Lukas

On Wed, Feb 6, 2013 at 3:32 PM, Sebastian Rachuj <rachus@web.de> wrote:

> Hello,
>
> I didn't see any further development in the last two weeks, so I thought
> that maybe I could help a bit. Since I didn't know where to start, I just
> made the *property* methods of "File" virtual and added the missing metho=
ds
> in other classes. Additionally I fixed a warning (virtual destructor for
> =91TagLib::FileRef::FileTypeResolver=92).
> I hope this patch could help with development.
>
> Best regards
> _______________________________________________
> taglib-devel mailing list
> taglib-devel@kde.org
> https://mail.kde.org/mailman/listinfo/taglib-devel
>
>

[Attachment #5 (text/html)]

<div dir="ltr"><div style>Hi Sebastian,</div><div style><br></div><div style>Thank \
you for the patch, but I&#39;m afraid this is duplicate work that has already been \
done.</div><div><br></div>These methods are not virtual in the &quot;master&quot; \
branch for ABI compatibility reasons. I think that all of them are already fixed in \
the &quot;taglib2&quot; branch:<div>

<br></div><div><a href="https://github.com/taglib/taglib/tree/taglib2">https://github.com/taglib/taglib/tree/taglib2</a><br><div><br></div><div \
style>Lukas<br></div></div></div><div class="gmail_extra"><br><br><div \
class="gmail_quote">

On Wed, Feb 6, 2013 at 3:32 PM, Sebastian Rachuj <span dir="ltr">&lt;<a \
href="mailto:rachus@web.de" target="_blank">rachus@web.de</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex">

Hello,<br>
<br>
I didn&#39;t see any further development in the last two weeks, so I thought that \
maybe I could help a bit. Since I didn&#39;t know where to start, I just made the \
*property* methods of &quot;File&quot; virtual and added the missing methods in other \
classes. Additionally I fixed a warning (virtual destructor for \
‘TagLib::FileRef::FileTypeResolver’).<br>

I hope this patch could help with development.<br>
<br>
Best regards<br>_______________________________________________<br>
taglib-devel mailing list<br>
<a href="mailto:taglib-devel@kde.org">taglib-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/taglib-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/taglib-devel</a><br> \
<br></blockquote></div><br></div>

_______________________________________________
taglib-devel mailing list
taglib-devel@kde.org
https://mail.kde.org/mailman/listinfo/taglib-devel

[prev in list] [next in list] [prev in thread] [next in thread] 