[prev in list] [next in list] [prev in thread] [next in thread] 

List:       taglib-devel
Subject:    Re: TagLibAmalgam: A new way to use TagLib
From:       Sander Jansen <s.jansen () gmail ! com>
Date:       2012-04-19 14:29:16
Message-ID: CACj81kGpe+ZkKx47d5Vxh1RedqWSvbL1XPJK_tqLipvEvxTiCA () mail ! gmail ! com
[Download RAW message or body]

On Thu, Apr 19, 2012 at 8:31 AM, Manfred Schwind <lists@mani.de> wrote:
> > Fixing the warnings means submitting a pull request for a change to
> > the official taglib repository
> 
> Maybe I should try that. ;-)
> 
> > you can't fix a warning in the amalgamation
> 
> True, of course. That's what I said.
> 
> > A non virtual destructor could in theory be a problem, if a derived
> > class is deleted through an alias to its base. Does this happen in
> > practice? I rather doubt it.
> 
> "Delete called on 'const TagLib::FileRef::FileTypeResolver' that is abstract"
> sounds like that's the case here. An abstract class can't be instantiated, so the \
> "real" class of the deleted instance must be some derived class. 

Those could be issues that cannot be fixed without changing the ABI
(which you usually want to avoid in stable release). Not a big deal
for whatever you're trying to do.

Sander
_______________________________________________
taglib-devel mailing list
taglib-devel@kde.org
https://mail.kde.org/mailman/listinfo/taglib-devel


[prev in list] [next in list] [prev in thread] [next in thread]