[prev in list] [next in list] [prev in thread] [next in thread] 

List:       taglib-devel
Subject:    RE: iterators+multithreading on win32
From:       "Brett Hoyle" <kickbits () gmail ! com>
Date:       2011-03-19 5:55:42
Message-ID: 001201cbe5fa$285e1430$791a3c90$ () gmail ! com
[Download RAW message or body]

Ok found the issue:
http://www.devx.com/tips/Tip/14540

Taglib.h line 51 should be:

#  define NOMINMAX
#  include <windows.h>


This allows it to compile fine under VS 2010.

-----Original Message-----
From: Lukáš Lalinský [mailto:lalinsky@gmail.com] 
Sent: Friday, 18 March 2011 8:51 PM
To: taglib-devel@kde.org
Subject: Re: iterators+multithreading on win32

On Fri, Mar 18, 2011 at 9:26 AM, Brett Hoyle <kickbits@gmail.com> wrote:
> Since these commits taglib no longer can compile under Visual Studio 2010.
>
> \Taglib\riff\rifffile.cpp line 175
> 1>..\riff\rifffile.cpp(175): error C2589: '(' : illegal token on right 
> 1>side
> of '::'
> 1>..\riff\rifffile.cpp(175): error C2059: syntax error : '::'
>
> Issue is std::max "Error: expected an identifier"
>
>
> Seems to be related to the include of windows.h in 
> \taglib\toolkit\taglib.h on line 51

We probably relied on some header file to include <algorithm>. Can you
please try to check if adding #include <algorithm> to rifffile.cpp fixes the
problem?

Lukas
_______________________________________________
taglib-devel mailing list
taglib-devel@kde.org
https://mail.kde.org/mailman/listinfo/taglib-devel

_______________________________________________
taglib-devel mailing list
taglib-devel@kde.org
https://mail.kde.org/mailman/listinfo/taglib-devel

[prev in list] [next in list] [prev in thread] [next in thread]