From taglib-devel Fri Jan 13 22:53:45 2006 From: Michael Pyne Date: Fri, 13 Jan 2006 22:53:45 +0000 To: taglib-devel Subject: Re: itunes mp4 files Message-Id: <200601131801.39513.pynm0001 () comcast ! net> X-MARC-Message: https://marc.info/?l=taglib-devel&m=113719282514889 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1765352666==" --===============1765352666== Content-Type: multipart/signed; boundary="nextPart5523548.KT2jZ7fzbN"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit --nextPart5523548.KT2jZ7fzbN Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Monday 09 January 2006 17:21, Jochen Issing wrote: > > The features are for now read only of almost all supported mp4 itunes > > fields, cover is left out for now, but could be included as well. No > > AudioProperties support yet, but will be my upcoming work. Write support > > will be last step for implementation, because this will be the most > > difficult part for me, especially rearding the offset tables, which I do > > not need to touch now. Hey, this is pretty awesome. :) (Sorry for the late reply, btw) > > Besides that the code is not completely cleaned up (some #if > > 0-statements), because I might need those in future work. I tried to do > > as much Doxygen comments as I was able to do - the License Header is > > missing in some files as well. May I ask how you're doing this work? There is existing code out there to= =20 merge MPEG-4 into TagLib but it is derived from mplayer (or libfaad, I forg= et=20 which) and is thus license incompatible. If your work were to make its way to TagLib it would have to carry the same= =20 (or less restrictive) license. But if you managed to write the code by reverse-engineering the format or=20 using documentation (i.e. not just reimplementing from other code), that=20 would probably be OK. > > Please give me your opinion on the code, if the coding rules are matched > > good enough, if the structure is Ok or whatever. At least, give it a tr= y! > > ;-) Um, where *is* the code? Regards, - Michael Pyne --nextPart5523548.KT2jZ7fzbN Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) iD8DBQBDyDFTqjQYp5Omm0oRAvxHAJsGqiXcmv5L4WMbqbFD8FCee1uZHACgs04P 5n7q0viNXO2a6APqCxUGK1A= =Pfax -----END PGP SIGNATURE----- --nextPart5523548.KT2jZ7fzbN-- --===============1765352666== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ taglib-devel mailing list taglib-devel@kde.org https://mail.kde.org/mailman/listinfo/taglib-devel --===============1765352666==--