[prev in list] [next in list] [prev in thread] [next in thread] 

List:       taglib-devel
Subject:    Re: m4a/mp4 itunes files
From:       Scott Wheeler <wheeler () kde ! org>
Date:       2005-11-22 15:35:23
Message-ID: 200511221635.24076.wheeler () kde ! org
[Download RAW message or body]

On Monday 21 November 2005 19:40, Jochen Issing wrote:
> I really understand your objections and I can second some of them. What I
> am thinking about is a small standalone implementation without the use of
> external libs etc. But I need to prepare myself and check for former
> implementations. I will not give you untested files, of that you can be
> sure. Do you have sth like coding rules, etc or is it mentioned in the code
> somewhere?

As Michael pointed out it pretty closely follows the conventions in JuK's 
HACKING file.  The notable differences are:

- Heavy use of namespaces; this should be fairly clear from looking at other 
classes

- 2 spaces instead of 4; no tabs

- no member variables other than a d-pointer, see: 
 http://developer.kde.org/documentation/other/binarycompatibility.html
 "Using a d-pointer".  As a side note Qt 4 has also gone the "no member 
 variables" route as well.

If you're worried about style issues just send a patch to the list once you've 
got some of the basics done and that can be reviewed and that might give you 
an idea of what's lacking prior to working on a full patch and then dealing 
with the nitpicking.  :-)

-Scott
_______________________________________________
taglib-devel mailing list
taglib-devel@kde.org
https://mail.kde.org/mailman/listinfo/taglib-devel
[prev in list] [next in list] [prev in thread] [next in thread]