[prev in list] [next in list] [prev in thread] [next in thread] 

List:       systemd-devel
Subject:    [systemd-devel] [PATCH v2] systemd-analyze: filter dot output
From:       lennart () poettering ! net (Lennart Poettering)
Date:       2013-03-29 15:59:33
Message-ID: 20130329155933.GK22747 () tango ! 0pointer ! de
[Download RAW message or body]

On Tue, 26.03.13 20:44, ?ukasz Stelmach (stlman at poczta.fm) wrote:

> @@ -104,6 +104,12 @@
>                  is passed the generated graph will show both ordering
>                  and requirement dependencies.</para>
>  
> +                <para>Optional patterns may be given to limit the
> +                output. With one pattern all lines for which at least
> +                one of the unit names matches the pattern shall be
> +                printed. With two patterns, the lines for which the
> +                units match patterns respectively.</para>

Hmm, not sure I like it this way too much. Somehow I would have assumed
that this works like it does on the shell, i.e. you can name as many
globs as you wish, and they would be treated the same way. 

Now, if we want to expose what your patch currently does I'd prefer if
we did this via cmdline switches. i.e. "--pattern=*.target",
"--from-pattern=*.service", or "--to-pattern=*.waldo",

Also, if this is parsed out of the command line it's fine to place this
in global vars whose name is prefixed with "arg_" or so...

Lennart

-- 
Lennart Poettering - Red Hat, Inc.

[prev in list] [next in list] [prev in thread] [next in thread]