[prev in list] [next in list] [prev in thread] [next in thread] 

List:       sylpheed
Subject:    [sylpheed:25763] [PATCH] popup_on_errors
From:       Lukas Zapletal <lukas.zapletal () qcm ! cz>
Date:       2005-09-20 10:32:21
Message-ID: 20050920123221.5458c0d7.lukas.zapletal () qcm ! cz
[Download RAW message or body]

Hi there!

As I promised, I am including a patch that is adding one configuration
value: popup_on_errors (default TRUE). Including the patch doesnt
change anything, but after this, one will be able to set this value in
the sylpheedrc and switch off the annoying message boxes.

This could help a lot to people with unstable connections
(GPRS/EDGE...).

The patch is in unified format against the current SVN version from
this morning (r592).

# trunk> svn diff > popup_on_errors.patch

-- 
S pozdravem / Best regards
Lukas Zapletal
sefredaktor / editor-in-chief
LinuxEXPRES - opravdovy linuxovy magazin
www.LinuxEXPRES.cz
tel.:+420 777 003 843

["popup_on_errors.patch" (text/x-patch)]

Index: libsylph/prefs_common.c
===================================================================
--- libsylph/prefs_common.c	(revision 592)
+++ libsylph/prefs_common.c	(working copy)
@@ -54,6 +54,8 @@
 	 P_BOOL},
 	{"newmsg_notify_command", NULL, &prefs_common.newmsg_notify_cmd,
 	 P_STRING},
+	{"popup_on_errors", "TRUE", &prefs_common.popup_on_errors,
+	 P_BOOL},
 
 	/* Send */
 	{"use_ext_sendmail", "FALSE", &prefs_common.use_extsend, P_BOOL},
Index: libsylph/prefs_common.h
===================================================================
--- libsylph/prefs_common.h	(revision 592)
+++ libsylph/prefs_common.h	(working copy)
@@ -58,6 +58,7 @@
 	gboolean chk_on_startup;
 	gboolean enable_newmsg_notify;
 	gchar *newmsg_notify_cmd;
+	gboolean popup_on_errors;
 
 	/* Send */
 	gboolean use_extsend;
Index: src/inc.c
===================================================================
--- src/inc.c	(revision 592)
+++ src/inc.c	(working copy)
@@ -1169,7 +1169,10 @@
 			log_warning("%s\n", log_msg);
 	}
 	if (err_msg) {
-		alertpanel_error(err_msg);
+		if (prefs_common.popup_on_errors)
+			alertpanel_error(err_msg);
+		else
+			statusbar_print_all(err_msg);
 		g_free(err_msg);
 	}
 }


[prev in list] [next in list] [prev in thread] [next in thread]