[prev in list] [next in list] [prev in thread] [next in thread] 

List:       sylpheed
Subject:    [sylpheed:23712] patch for signing plain ASCII mails
From:       Thorsten Maerz <torte () netztorte ! de>
Date:       2004-12-18 9:23:33
Message-ID: 20041218102333.00000f70 () sirius
[Download RAW message or body]

[Attachment #2 (multipart/mixed)]


Hi Hiro,

there is a problem when gpg signing messages that are
plain ASCII, they are neither quoted-printable nor
base64 encoded, though required by rfc3156 par. 3.

If those messages contain trailing spaces, they will
give different results when checked with a different
gpg version than it was signed with (the problem starts
showing up with gpg-1.4 <-> gpg-1.2).

I also think that clearsigned messages should be
encoded as well to protect trailing spaces being
stripped by MTA/MDAs.

The attached patch (against 1.0.0rc tarball) should
fix this.

Best regards,
--=20
Thorsten Maerz          <torte@netztorte.de>
Sylpheed-claws/Win32:   http://claws-w32.sf.net

["compose.c.diff" (text/plain)]

--- compose.c.old	2004-12-18 09:35:36.000000000 +0100
+++ compose.c	2004-12-18 09:57:37.000000000 +0100
@@ -2644,13 +2644,6 @@
 		else
 			encoding = procmime_get_encoding_for_charset(out_codeset);
 
-#if USE_GPGME
-		if (!is_draft &&
-		    compose->use_signing && !compose->account->clearsign &&
-		    encoding == ENC_8BIT)
-			encoding = ENC_BASE64;
-#endif
-
 		src_codeset = conv_get_current_charset_str();
 		/* if current encoding is US-ASCII, set it the same as
 		   outgoing one to prevent code conversion failure */
@@ -2691,6 +2684,9 @@
 	buf = canon_buf;
 
 #if USE_GPGME
+	if (!is_draft && compose->use_signing &&
+	    (encoding == ENC_8BIT || encoding == CTE_AUTO))
+		encoding = ENC_BASE64;
 	if (!is_draft && compose->use_signing && compose->account->clearsign) {
 		if (compose_clearsign_text(compose, &buf) < 0) {
 			g_warning("clearsign failed\n");

[Attachment #6 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]