[prev in list] [next in list] [prev in thread] [next in thread] 

List:       sylpheed
Subject:    [sylpheed:23666] Re: Sylpheed 1.0.0beta4 released
From:       Hiroyuki Yamamoto <hiro-y () kcn ! ne ! jp>
Date:       2004-12-08 8:56:14
Message-ID: 20041208175614.7325a239.hiro-y () kcn ! ne ! jp
[Download RAW message or body]

Hello,

On Sat, 4 Dec 2004 00:22:42 +0100
Alfons Hoogervorst <alfons@proteus.demon.nl> wrote:

> Two small patches that do not affect stability, please apply.
> 
> bitlength_clean_up.imap.c.patch:
> 
> 	The "%u" scan format type is for the platform's
> 	unsigned integer, which may be 64 bits, or longer. 
> 	imap.c tries to cram those in explicitly typed
> 	guint32s. This patch fixes that.

Applied.

> obey_linewrap_quote_prefs.compose.c.patch:
> 
> 	The line wrapping in quote pref does not work,
> 	this patch makes it work. (Oddly, been that way
> 	for a long time, and no-one seems to have missed
> 	it; see:
> http://sourceforge.net/mailarchive/forum.php?thread_id=6071445&forum_id=2006

At least it is expected behavior: the intention of the option is whether
to wrap quotation 'automatically on reply'.

Applying that patch breaks wrapping of quotation part anyway (that's
why linewrap_quote is always TRUE). Maybe compose_wrap_line_all()
shouldn't touch quoted part at all if it's FALSE.

> I think Colin has a patch that fixes minor parsing problems with email
> addresses.

I think that modification is not trivial, so I'll hold back it for now.

> Also, Hiro, as a developer grepping my way through sylpheed's source
> since November 2000, ***thanks*** for the great job you've been doing
> the past four years!

Thanks, but it's still on the long way to the goal :)

-- 
Hiroyuki Yamamoto <hiro-y@kcn.ne.jp>

[prev in list] [next in list] [prev in thread] [next in thread]