[prev in list] [next in list] [prev in thread] [next in thread] 

List:       sylpheed
Subject:    [sylpheed:21644] when entering a folder
From:       Onur Kucuk <onur () delipenguen ! net>
Date:       2003-09-24 20:10:13
[Download RAW message or body]



 Hello,

  In the "Configuration-> Common Preferences-> Interface" the options "Always open messages in summary \
when selected" and "Open first unread message when entering a folder" seem to have some trouble.

 If "Always ..." is selected, Sylpheed does not care wheter "Open first ..." is selected or not. The \
patch below fixes it.

 I think instead of having an "Open first unread message ..." option, there should be a "Select first \
unread message ..." option. Right now one can not make a "When I enter a folder, go to the first unread \
message but do not mark it as read" rule, but if the "Open" is changed to "Select" this can be done. Also \
if one wants the message to be opened, he can select "Always open messages ..." in this case.

 Any suggestions ?


diff -Nur sylpheed-0.9.6/src/summaryview.c
sylpheed-0.9.6-edited/src/summaryview.c
--- sylpheed-0.9.6/src/summaryview.c    2003-09-17 07:15:27.000000000
+0300
+++ sylpheed-0.9.6-edited/src/summaryview.c     2003-09-24
20:20:44.000000000 +0300
@@ -688,13 +688,12 @@
                                 item->sort_type == SORT_DESCENDING
                                 ? 0 : GTK_CLIST(ctree)->rows - 1);
                }
-               if (prefs_common.open_unread_on_enter ||
-                   prefs_common.always_show_msg) {
+               if (prefs_common.open_unread_on_enter) {
                        summary_unlock(summaryview);
                        summary_select_node(summaryview, node, TRUE, TRUE);
                        summary_lock(summaryview);
                } else
-                       summary_select_node(summaryview, node, FALSE,TRUE);
+                       summary_select_node(summaryview, node, prefs_common.always_show_msg, TRUE);
        }

        summary_set_column_titles(summaryview);


-- 
 Regards,
 Onur Kucuk


[prev in list] [next in list] [prev in thread] [next in thread]