[prev in list] [next in list] [prev in thread] [next in thread] 

List:       svk-devel
Subject:    [svk-devel] Patches?
From:       sartak () gmail ! com (Sartak)
Date:       2007-09-20 23:13:26
Message-ID: e7e9b6ab0709202013j4cd0479dxc796080622ae8e18 () mail ! gmail ! com
[Download RAW message or body]

Hi Ken,

On 9/19/07, Kenneth Swanson <kswanson@watson.wustl.edu> wrote:
> Hello all,
> 
> I haven't done much submitting to open source projects and I was curious--if I want \
> to submit a patch to SVK, how should I do it, and what steps should I take?
> 
> I have a very small change to SVK/Command/Checkout.pm; I changed the -l option so \
> that if you use it and your depot path names are especially long (> 30 chars, as \
> mine tend to be :) ), you get a nicely formatted output, instead of having some of \
> the checkout paths further right than you want.
> 
> This is mostly just a vanity change for me, but I'd still like to put it in there.  \
> I've downloaded the source tarball from CPAN, and tried running prove -I lib/ t, \
> and I got 3 failed tests, but 2 of them seem to just be because I changed the \
> format, and not actually broken.  The third (t/60patchset.t), I'm not sure on.
> 
> What should I do from here?  Should I submit my patch, or try to get all test to \
> work?  Do I have to do a make install for all tests to work?

Getting all the tests (or at least the two that broke because of the
format change) to pass would be helpful. You shouldn't need to use
make install (especially if you're using `make test` or `prove -l`).

For that third test, does it still break if you revert your checkout?
The output from that failing test would be useful to see, either way.

> 
> Any help would be appreciated.  Thanks,
> 
> -Ken Swanson
> _______________________________________________
> svk-devel mailing list
> svk-devel@bestpractical.com
> http://lists.bestpractical.com/cgi-bin/mailman/listinfo/svk-devel
> 

Shawn


[prev in list] [next in list] [prev in thread] [next in thread]