[prev in list] [next in list] [prev in thread] [next in thread] 

List:       svk-commit
Subject:    [svk-commit] r2413 - branches/svk-logger/lib/SVK
From:       nobody () bestpractical ! com (nobody () bestpractical ! com)
Date:       2007-06-21 5:05:46
Message-ID: 20070621090543.30C884D81E0 () diesel ! bestpractical ! com
[Download RAW message or body]

Author: clsung
Date: Thu Jun 21 05:05:42 2007
New Revision: 2413

Modified:
   branches/svk-logger/lib/SVK/Command.pm

Log:
- this will pass t/01depotmap.t
- patch says 
  -    unless (ref($@)) {
  -       print $@ if $@;
  +    if ($@ && ref($@)) {
  +        $logger->info("$@");

- and I modify the if statement to 
       if ($@ && !ref($@)) {
- this should match the original semantic


Modified: branches/svk-logger/lib/SVK/Command.pm
==============================================================================
--- branches/svk-logger/lib/SVK/Command.pm	(original)
+++ branches/svk-logger/lib/SVK/Command.pm	Thu Jun 21 05:05:42 2007
@@ -165,7 +165,7 @@
 
     $ofh = select STDERR unless $output;
     $logger->info( $ret) if $ret && $ret !~ /^\d+$/;
-    if ($@ && ref($@)) {
+    if ($@ && !ref($@)) {
         $logger->info("$@");
     }
     $ret = 1 if ($ret ? $ret !~ /^\d+$/ : $@);

[prev in list] [next in list] [prev in thread] [next in thread]