[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-issues
Subject:    [Issue 4591] New - ruby.h includes config.h and standard libraries -- should be first include for ru
From:       risto3 () tigris ! org
Date:       2015-08-25 12:00:43
Message-ID: iz4591 () subversion ! tigris ! org
[Download RAW message or body]

http://subversion.tigris.org/issues/show_bug.cgi?id=4591
                 Issue #|4591
                 Summary|ruby.h includes config.h and standard libraries -- sho
                        |uld be first include for ruby client
               Component|subversion
                 Version|1.9.x
                Platform|Sun
                     URL|
              OS/Version|All
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P3
            Subcomponent|bindings_swig_ruby
             Assigned to|issues@subversion
             Reported by|risto3






------- Additional comments from risto3@tigris.org Tue Aug 25 05:00:42 -0700 2015 -------
since ruby.h includes config.h correctly prior to including standard libraries,
this causes warnings and potentially erroneous behaviour if any standard
libraries are include prior to ruby.h.

Example:
--- subversion/bindings/swig/ruby/core.lo ---
In file included from
/tmp/pkgsrc/devel/ruby-subversion/work/.buildlink/include/ruby-2.0.0/ruby/ruby.h:24:0,
                 from
/tmp/pkgsrc/devel/ruby-subversion/work/.buildlink/include/ruby-2.0.0/ruby.h:33,
                 from subversion/bindings/swig/ruby/core.c:821:
/tmp/pkgsrc/devel/ruby-subversion/work/.buildlink/include/ruby-2.0.0/i486-solaris2.11/ruby/config.h:51:0:
warning: "_FILE_OFFSET_BITS" redefined
 #define _FILE_OFFSET_BITS 64
 ^
In file included from /usr/include/iso/string_iso.h:49:0,
                 from
/opt/local/gcc49/lib/gcc/i486-sun-solaris2.11/4.9.3/include-fixed/string.h:42,
                 from subversion/bindings/swig/ruby/core.c:406:
/opt/local/gcc49/lib/gcc/i486-sun-solaris2.11/4.9.3/include-fixed/sys/feature_tests.h:231:0:
note: this is the location of the previous definition
 #define _FILE_OFFSET_BITS 32
 ^

also happens with:
subversion/bindings/swig/ruby/svn_client.lo
subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.lo
subversion/bindings/swig/ruby/svn_delta.lo
subversion/bindings/swig/ruby/svn_ra.lo
subversion/bindings/swig/ruby/svn_repos.lo
subversion/bindings/swig/ruby/svn_diff.lo
subversion/bindings/swig/ruby/svn_fs.lo
subversion/bindings/swig/ruby/svn_wc.lo

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=463&dsMessageId=3133960

To unsubscribe from this discussion, e-mail: [issues-unsubscribe@subversion.tigris.org].
[prev in list] [next in list] [prev in thread] [next in thread]