[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-issues
Subject:    [Issue 4359] New - wrong notification during repository packing
From:       philip () tigris ! org
Date:       2013-04-23 12:36:30
Message-ID: iz4359 () subversion ! tigris ! org
[Download RAW message or body]

http://subversion.tigris.org/issues/show_bug.cgi?id=4359
                 Issue #|4359
                 Summary|wrong notification during repository packing
               Component|subversion
                 Version|1.7.x
                Platform|All
                     URL|
              OS/Version|All
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P3
            Subcomponent|libsvn_repos
             Assigned to|issues@subversion
             Reported by|philip






------- Additional comments from philip@tigris.org Tue Apr 23 05:36:30 -0700 2013 -------
The repos layer converts the FS packing actions to repos actions but gets it
wrong.  The result is that "svnadmin pack" doesn't display notifications in 1.7
or 1.8.  The testsuite fails due to unexpected notifications with this patch:

Index: ../src/subversion/libsvn_repos/fs-wrap.c
===================================================================
--- ../src/subversion/libsvn_repos/fs-wrap.c	(revision 1470841)
+++ ../src/subversion/libsvn_repos/fs-wrap.c	(working copy)
@@ -740,7 +740,10 @@ pack_notify_func(void *baton,
   struct pack_notify_baton *pnb = baton;
   svn_repos_notify_t *notify;
 
-  notify = svn_repos_notify_create(pack_action + 3, pool);
+  notify = svn_repos_notify_create(pack_action
+                                   + svn_repos_notify_pack_shard_start
+                                   - svn_fs_pack_notify_start,
+                                   pool);
   notify->shard = shard;
   pnb->notify_func(pnb->notify_baton, notify, pool);

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=463&dsMessageId=3054029

To unsubscribe from this discussion, e-mail: [issues-unsubscribe@subversion.tigris.org].
[prev in list] [next in list] [prev in thread] [next in thread]