[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-issues
Subject:    =?UTF-8?B?W0lzc3VlIDIxMDhdIE5ldyAtIHN2bl9wYXRoX2Nhbm9uaWNhbGl6ZQ==?=
From:       rosch () tigris ! org
Date:       2004-10-26 9:53:57
Message-ID: 20041026095357.14290.qmail () tigris ! org
[Download RAW message or body]

http://subversion.tigris.org/issues/show_bug.cgi?id=2108
                  Issue #:|2108
                  Summary:|svn_path_canonicalize() broken in 1.1.x on cygwin
                Component:|subversion
                  Version:|1.1.x
                 Platform:|PC
                      URL:|
               OS/Version:|Windows XP
                   Status:|NEW
        Status whiteboard:|
                 Keywords:|
               Resolution:|
               Issue type:|DEFECT
                 Priority:|P3
             Subcomponent:|libsvn_subr
              Assigned to:|issues@subversion
              Reported by:|rosch






------- Additional comments from rosch@tigris.org Tue Oct 26 02:53:57 -0700 2004 -------
Subversion 1.1.x can not find the users .subversion folder in his/her
homeaccount on cygwin when the homeaccount resides on an UNC share.

Subversion 1.0.9 is not showing the behaviour. Everything is fine. So I was
taking a look in the code. apr is identical in 1.0.9 and 1.1.1. So it couldn't
be the failing instance here. So I looked further and found that 
svn_path_canonicalize() in subversion/libsvn_subr is broken in 1.1.x when
running on cygwin and getting an UNC path.

Example:
//server/share/folder
will result in
/server/share/folder
after svn_path_canonicalize()

The reason for it is that the leading / gots stripped here. There is an #ifdef
for win32 taking care of double leading seperators but not for cygwin.

So replacing the 2 occurencies of
#ifdef WIN32
in svn_path_canonicalize() with
#if defined(WIN32) || defined(CYGWIN)

fixed the problem for me. I attached a patch for this problem basing on the
current 1.1.1 release code

I haven't read the HACKING file so this is just a suggestion how it can be
fixed. Feel free to ignore it and use another solution for this if you find it
better suitable.

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@subversion.tigris.org
For additional commands, e-mail: issues-help@subversion.tigris.org

[prev in list] [next in list] [prev in thread] [next in thread]