[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-issues
Subject:    [Issue 977] Changed - no support for 'svn diff -rBASE:HEAD'
From:       issues () subversion ! tigris ! org
Date:       2002-12-29 17:38:34
[Download RAW message or body]

http://subversion.tigris.org/issues/show_bug.cgi?id=977

*** Old
--- New
***************
*** 41,43 ****
--- 41,64 ----
  ------- Additional Comments From kfogel@tigris.org  2002-12-20 18:30 PST -------
  Revision 4186 (which resolved issue #1028) may be relevant to the
  resolution of this issue too.
+ 
+ 
+ ------- Additional Comments From rooneg@tigris.org  2002-12-29 09:38 PST -------
+ ok, i've got a patch to do what ben suggests (the easy way), but i'm
+ not sure we should go with it.  all it does is remove the checks for
+ svn_opt_revision_base from the third option in do_diff,  then we go
+ and do the diff between whatever the target's base revision is and HEAD.
+ 
+ unfortunately, if we diff HEAD against the revision we get from BASE,
+ the we're assuming that the whole working copy is at that revision,
+ which isn't necessarily the case.
+ 
+ the 'right' way to do this seems to be to have the wc diff editor be
+ able to diff against the text-base as well as against the actual
+ working copy.  of course this is a much more annoying change, but it
+ would allow us to give what seems like the correct output for this case.
+ 
+ any thoughts?  am i on crack? have i misssed something?  or should we
+ just take the easy way out, since the user told us to diff between the
+ target's base and HEAD, so our 'wrong' output is what they asked for
+ anyway...
\ No newline at end of file

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@subversion.tigris.org
For additional commands, e-mail: issues-help@subversion.tigris.org


[prev in list] [next in list] [prev in thread] [next in thread]