[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-dev
Subject:    Re: [Regression in httpd 2.4.49] mod_dav: REPORT requests no longer return errors
From:       Ruediger Pluem <rpluem () apache ! org>
Date:       2021-09-24 6:43:07
Message-ID: e626e0fe-120e-95d9-3730-090eee435b56 () apache ! org
[Download RAW message or body]



On 9/22/21 4:08 PM, Ruediger Pluem wrote:
> 
> 
> On 9/22/21 3:49 PM, Evgeny Kotkov wrote:
> > Ruediger Pluem <rpluem@apache.org> writes:
> > 
> > > Does the attached patch solve your issue?
> > 
> > It does appear to solve the problem with missing errors, thanks!
> > 
> > I haven't checked that in detail, but I think there might be a discrepancy
> > in how `err` is handled in the patch and for example when calling the
> > method_precondition() hook.
> > 
> > With the patch, `err` is checked even if all hooks DECLINE the operation.
> > Not too sure if that's intended, because the variable could potentially
> > contain an arbitrary value or a leftover from some previous call.
> 
> The below new version should address the case that there was a left over in err \
> from calling dav_run_method_precondition by resetting err to NULL.
> If we should ignore err if all hooks return DECLINED but set err, to be honest I \
> don't know. I hope for someone with more DAV insights to comment and tell me, what \
> is correct here :-). Depending on this it should be easy to adjust the patch \
> accordingly if needed.

r1893589

Regards

Rüdiger


[prev in list] [next in list] [prev in thread] [next in thread]