[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-dev
Subject:    Re: [swig-py3][patch] interfacing bytes object instead of str
From:       Troy Curtis Jr <troycurtisjr () apache ! org>
Date:       2018-12-31 4:16:07
Message-ID: CAEZNtZLJ1531o-SaeektnNKso0mh9ba9RgD9ff2w7bJ9X_4AXw () mail ! gmail ! com
[Download RAW message or body]

On Fri, Dec 28, 2018 at 8:20 AM Yasuhito FUTATSUKI <futatuki@poem.co.jp>
wrote:

> On 12/28/18 4:09 AM, Troy Curtis wrote:
> > LGTM, committed as r1849804, but without the unnecessary gymnastics to
> continue supporting str() in those two cases mentioned above. I also
> tweaked the log message to use complete sentences (and removed references
> to the code that I didn't include).
>
> Thank you for correct my broken log message.
>
> As the second step of follow up r1849784, I've fixed #if blocks usage
> in subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c because
> it is obvious and it doesn't contain any functional change.
>
> follow up r189784: fix macro usage to distinguish py2 and py3 context
>
> * subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
>    Include "swigutil_py3c.h" file before define SVN_SWIG_BYTES_FMT to use
>    IS_PY3 macro to switch py2 and py3 context
>    (add_directory, add_file, apply_textdelta, change_file_prop,
>     close_file, parse_fn3_set_revision_property,
>     parse_fn3_set_node_property, svn_swig_py_notify_func,
>     svn_swig_py_notify_func, svn_swig_py_delta_path_driver_cb_func,
>     svn_swig_py_repos_authz_func, svn_swig_py_log_receiver,
>     svn_swig_py_client_blame_receiver_func,
>     svn_swig_py_changelist_receiver_func,
>     svn_swig_py_auth_simple_prompt_func,
>     svn_swig_py_config_auth_walk_func,
>     ra_callbacks_get_wc_prop, ra_callbacks_push_or_set_wc_prop,
>     ra_callbacks_invalidate_wc_props, svn_swig_py_commit_callback,
>     reporter_set_path, reporter_link_path,
>     wc_diff_callbacks2_file_changed_or_added,
>     wc_diff_callbacks2_file_deleted, wc_diff_callbacks2_dir_added,
>     wc_diff_callbacks2_dir_props_changed,
>     svn_swig_py_config_enumerator2):
>      Use IS_PY3 macro instead of comparison of PY_VERSION_HEX
>    (add_directory, add_file, apply_textdelta, change_file_prop,
>     close_file, parse_fn3_set_revision_property,
>     parse_fn3_set_node_property, ra_callbacks_get_wc_prop,
>     ra_callbacks_push_or_set_wc_prop, ra_callbacks_invalidate_wc_props):
>      Enclose only format argument of Py_CallFunction or Py_CallMethod
>      with #if IS_PY3 #else #endif block
>

Great! LGTM, committed as r1850011.


> Cheers,
> --

Yasuhito FUTATSUKI
>

Troy

[Attachment #3 (text/html)]

<div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><br></div><br><div \
class="gmail_quote"><div dir="ltr">On Fri, Dec 28, 2018 at 8:20 AM Yasuhito FUTATSUKI \
&lt;<a href="mailto:futatuki@poem.co.jp">futatuki@poem.co.jp</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 12/28/18 4:09 AM, \
Troy Curtis wrote:<br> &gt; LGTM, committed as r1849804, but without the unnecessary \
gymnastics to continue supporting str() in those two cases mentioned above. I also \
tweaked the log message to use complete sentences (and removed references to the code \
that I didn&#39;t include).<br> <br>
Thank you for correct my broken log message.<br>
<br>
As the second step of follow up r1849784, I&#39;ve fixed #if blocks usage<br>
in subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c because<br>
it is obvious and it doesn&#39;t contain any functional change.<br>
<br>
follow up r189784: fix macro usage to distinguish py2 and py3 context<br>
<br>
* subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c<br>
     Include &quot;swigutil_py3c.h&quot; file before define SVN_SWIG_BYTES_FMT to \
use<br>  IS_PY3 macro to switch py2 and py3 context<br>
     (add_directory, add_file, apply_textdelta, change_file_prop,<br>
      close_file, parse_fn3_set_revision_property,<br>
      parse_fn3_set_node_property, svn_swig_py_notify_func,<br>
      svn_swig_py_notify_func, svn_swig_py_delta_path_driver_cb_func,<br>
      svn_swig_py_repos_authz_func, svn_swig_py_log_receiver,<br>
      svn_swig_py_client_blame_receiver_func,<br>
      svn_swig_py_changelist_receiver_func,<br>
      svn_swig_py_auth_simple_prompt_func,<br>
      svn_swig_py_config_auth_walk_func,<br>
      ra_callbacks_get_wc_prop, ra_callbacks_push_or_set_wc_prop,<br>
      ra_callbacks_invalidate_wc_props, svn_swig_py_commit_callback,<br>
      reporter_set_path, reporter_link_path,<br>
      wc_diff_callbacks2_file_changed_or_added,<br>
      wc_diff_callbacks2_file_deleted, wc_diff_callbacks2_dir_added,<br>
      wc_diff_callbacks2_dir_props_changed,<br>
      svn_swig_py_config_enumerator2):<br>
        Use IS_PY3 macro instead of comparison of PY_VERSION_HEX<br>
     (add_directory, add_file, apply_textdelta, change_file_prop,<br>
      close_file, parse_fn3_set_revision_property,<br>
      parse_fn3_set_node_property, ra_callbacks_get_wc_prop,<br>
      ra_callbacks_push_or_set_wc_prop, ra_callbacks_invalidate_wc_props):<br>
        Enclose only format argument of Py_CallFunction or Py_CallMethod<br>
        with #if IS_PY3 #else #endif block<br></blockquote><div><br></div><div>Great! \
LGTM, committed as r1850011.</div><div> <br></div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"> <br>
Cheers,<br>
--   </blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> Yasuhito FUTATSUKI \
<br></blockquote><div><br></div><div>Troy <br></div></div></div></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]