[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-dev
Subject:    Re: svn commit: r1829344 - in /subversion/trunk/build/ac-macros: lz4.m4 utf8proc.m4
From:       Branko_Čibej <brane () apache ! org>
Date:       2018-04-17 13:07:35
Message-ID: 0f336281-0158-2637-c828-f63c93ba04ce () apache ! org
[Download RAW message or body]

On 17.04.2018 13:34, Johan Corveleyn wrote:
> On Tue, Apr 17, 2018 at 1:15 PM, Philip Martin <philip@codematters.co.uk> wrote:
>> Johan Corveleyn <jcorvel@gmail.com> writes:
>>
>>> Maybe we could add an extra hint to the error message along the lines
>>> of "Maybe you want --with-lz4=internal"? To help self-serviceness and
>>> avoid mails to the users list ...
>> I don't think that is a good recommendation. Internal libraries should
>> only be used if the OS does not provide the library.
> OK.
>
> I just thought a common scenario of users running into this would be:
> - Try to build Subversion.
> - Fail because lz4 library is missing.
> - "Hmm, haven't seen this before, let's try if we can build without
> it, let's try --without-lz4".
> - Error ... Ah, it's required, damn. Now what? Do I have to go looking
> for yet another dependency of SVN?
> - Lose time, and perhaps give up.
>
> But if it's not recommended, then okay.
>
> Or would the following be useful and acceptable?
> "Subversion requires LZ4. It is recommended you use the most
> up-to-date version of the LZ4 library provided by your OS. If your OS
> does not provide one, you can use --with-lz4=internal to use the
> library included in the SVN release package."
>
> A bit long perhaps...
>
> It's just a thought ... not terribly important.

build/ac-macros/lz4.m4 suggests --with-lz4=internal in the version check
error message.

-- Brane

[prev in list] [next in list] [prev in thread] [next in thread]