[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-dev
Subject:    Re: Warnings from the bindings
From:       Branko_Čibej <brane () apache ! org>
Date:       2018-04-07 19:30:44
Message-ID: 5bafa8cd-39ca-7d75-d87e-47918d10ba6e () apache ! org
[Download RAW message or body]

On 07.04.2018 21:20, Philip Martin wrote:
> Branko Čibej <brane@apache.org> writes:
>
>> I'll take another look. At the very least this should be using the local
>> frame manager object, which is exception-safe, unlike explicitly pushing
>> and popping the frame.
> ImmutableList::for_each iterates and constructs arbitrary types T.  The
> problem occurs when T is ExternalItem as the constructor generates local
> refs from the get_string_field and get_revision_field calls.  It's
> possible that we should modify ExternalItem to avoid doing this, but
> for_each should also work with arbitrary types and so for_each should
> use a local frame.  I've comitted the for_each change.

Looks good, thanks!

-- Brane
[prev in list] [next in list] [prev in thread] [next in thread]