[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-dev
Subject:    Re: svn commit: r1572363 - in /subversion/trunk/subversion: include/ libsvn_fs/ libsvn_fs_base/ libs
From:       Ben Reser <ben () reser ! org>
Date:       2014-02-28 21:14:52
Message-ID: 5310FC4C.4000805 () reser ! org
[Download RAW message or body]

On 2/28/14, 1:07 PM, Stefan Fuhrmann wrote:
> Things are much worse, in fact. The old implementation
> would consider all property lists to be equal (FSFS only)
> because the representation_t structs are empty except
> for the txn_id. Hence, revision, offset and unifier would
> always match between any modified prop lists.

Ouch.

> r1573071 documents the problem in the API. Should we
> write an API errata?

Yes I think so.  I don't expect anyone to have expected that old behavior.

> This is incorrect. NULL prop list reps are equal to
> empty prop lists.

Ahh that makes sense.  Part of the reason I didn't commit it is what I expected
to find in the code so widely divergent from the way the code was that I wasn't
sure about what I'd done.

> r1573071 fixes the a!=a problem for in-txn items but that's
> the best we can do here without a content comparison.

Okay thanks!

[prev in list] [next in list] [prev in thread] [next in thread]