[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-dev
Subject:    Re: svn commit: r1570936 - /subversion/trunk/subversion/libsvn_client/blame.c
From:       Stefan Fuhrmann <stefan.fuhrmann () wandisco ! com>
Date:       2014-02-23 21:25:20
Message-ID: CA+t0gk3airFcT62bQ4ppP4u5DgJ=uoVO7J3yUZxxkFx1NH0TNQ () mail ! gmail ! com
[Download RAW message or body]

On Sun, Feb 23, 2014 at 12:06 AM, Bert Huijben <bert@qqmail.nl> wrote:

>  I think your patch doesn't change the behavior (this is more a brain
> dump based on te earlier related mail thread), but there are property
> changes that do change how we interpret the content of a file... E.g. some
> changes to svn:eol-style and svn:keywords.
>
> In these cases the actual file may change while the repository form didn't.
>
> Blame, especially with whitespace ignores might not be interested in these
> cases, but there are api users that use the file revs api that are
> interested.
>

Well, my patch does not fix the fundamental shortcomings
of blame nor do I intend to address them any time soon.

I simply wanted to remove the behavioral dependency on
FS implementation details. That's what this patch does and
tests pass with FSX again.

-- Stefan^2.

[Attachment #3 (text/html)]

<div dir="ltr"><br><div class="gmail_extra"><div class="gmail_quote">On Sun, Feb 23, \
2014 at 12:06 AM, Bert Huijben <span dir="ltr">&lt;<a href="mailto:bert@qqmail.nl" \
target="_blank">bert@qqmail.nl</a>&gt;</span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">




<div dir="ltr">
<div dir="ltr" style="font-family:&#39;Calibri&#39;,&#39;Segoe \
UI&#39;,&#39;Meiryo&#39;,&#39;Microsoft YaHei UI&#39;,&#39;Microsoft JhengHei \
UI&#39;,&#39;Malgun Gothic&#39;,&#39;sans-serif&#39;;font-size:12pt"><div>I think \
your patch doesn&#39;t change the behavior (this is more a brain dump based on te \
earlier related mail thread), but there are property changes that do change how we \
interpret the content of a file&hellip; E.g. some changes to svn:eol-style and \
svn:keywords.</div> <div><br></div><div>In these cases the actual file may change \
while the repository form didn&rsquo;t.</div><div><br></div><div>Blame, especially \
with whitespace ignores might not be interested in these cases, but there are api \
users that use the file revs api that are interested.</div> \
</div></div></blockquote><div><br></div><div>Well, my patch does not fix the \
fundamental shortcomings<br></div><div>of blame nor do I intend to address them any \
time soon.<br><br></div><div>I simply wanted to remove the behavioral dependency \
on<br> FS implementation details. That&#39;s what this patch does and<br>tests pass \
with FSX again.<br><br></div><div>-- Stefan^2.<br></div></div><br></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]