[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-dev
Subject:    Re: protorev file handling in svn_fs_commit_txn
From:       Philip Martin <philip.martin () wandisco ! com>
Date:       2013-11-26 17:26:16
Message-ID: 87ob579irr.fsf () ntlworld ! com
[Download RAW message or body]

Daniel Shahaf <d.s@daniel.shahaf.name> writes:

> Philip Martin wrote on Tue, Nov 26, 2013 at 16:52:38 +0000:
>> [ pointed out several problems ]
>
> I agree.
>
> It's still not clear to me how the repository you posted managed to get
> rep-cache.db to refer to the file rep at offset 0 --- a rep which isn't
> reachable from the root-node-offset at the end of the file.  In your
> simulation of the failure, did commit_baton get re-initialized between
> the failed and successful commit_body() calls?  I think in a normal
> situation it would be.

The failed commit and the successful commit were made by two separate
processes.  The rep_cache offest points to the text representation at
the start of the file, not to either file node representation.

-- 
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*

[prev in list] [next in list] [prev in thread] [next in thread]