[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-dev
Subject:    Re: svnserve - don't ignore errors
From:       Julian Foad <julianfoad () btopenworld ! com>
Date:       2013-11-25 11:46:54
Message-ID: 1385380014.89749.YahooMailNeo () web186102 ! mail ! ir2 ! yahoo ! com
[Download RAW message or body]

Stefan Fuhrmann wrote:

> On Thu, Nov 21, 2013 at 8:18 PM, Julian Foad wrote:
>> In r1544253 I added error checking to some socket initiliazation cases.
>> I haven't reproduced such errors, I just followed the obvious coding
>> pattern to add the missing checks.
>> 
>> I would appreciate a review of that to ensure it wasn't ignoring errors
>> on purpose in either of those places.
> 
> As far as I can tell, this should be fine. Svnserve has been somewhat
> neglected in the past, so things like error handling and logging were not
> particularly consistent. 1.9 is an improvement in this department.
> 
> I think we should simply document these changes in the release notes
> (just added a basic template for 1.9).


Thanks.
>> In r1544256 I added error checking to the main exit code path of both
>> inetd and tunnel modes. This one is easily demonstrated [...]
> 
> Same here. I love how the new sub_main() function makes all sorts
> of cleanup and error reporting much simpler.


Thanks, on both counts.

I have now mentioned these in the 'CHANGES' file.


- Julian


[prev in list] [next in list] [prev in thread] [next in thread]