[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-dev
Subject:    Re: [PATCH] Ensure full distribution description is printed in svn --version -v
From:       Ben Reser <ben () reser ! org>
Date:       2013-11-23 20:52:03
Message-ID: 52911573.8090001 () reser ! org
[Download RAW message or body]

On 11/23/13 12:41 PM, Andreas Stieger wrote:
> found a string handling issue:
> $ svn --version -v
> [...]
>   - openSUSE 12 (Mantis) [Linux 3.4.63-2.44-desktop]
> [...]         ^^^
> This when "lsb_release -a" clearly contains:
> Description:	openSUSE 12.2 (i586)
> 
> Turns out stringbuf_split_key calculates the buffer length incorrectly,
> causing the distribution name to be cut off after the length of the
> label instead of the remaining string, in this case 11 characters. Patch
> attached.
> 
> [[[
> Ensure full distribution description is printed in svn --version -v
> 
> * subversion/libsvn_subr/sysinfo.c
>   (stringbuf_split_key): fix buffer length calculation
> ]]]

Committed in r1544878 with my approval.



[prev in list] [next in list] [prev in thread] [next in thread]