[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-dev
Subject:    Re: Does fsfs revprop packing no longer allow usage of traditional backup software?
From:       Peter Samuelson <peter () p12n ! org>
Date:       2011-06-30 22:57:47
Message-ID: 20110630225747.GW4086 () p12n ! org
[Download RAW message or body]


[Hyrum K Wright]
> I like this idea, but it would seem to introduce an additional stat()
> call* for every attempt to fetch a revprop, because you'd first have
> to check the "old" location, and then the packed one.

Technically not an extra stat(), but an extra open().  Not the same.
Especially since the "common case", as you put it, is that the open()
returns ENOENT, file not found.  _That_ case may or may not be
expensive, but it's quite different from the usual consideration of
whether stat() is expensive.  Not least because stat() is usually
considered in context where a file _does_ exist and various information
about the file gets looked up to populate the stat structure.

Just sayin',
-- 
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/

[prev in list] [next in list] [prev in thread] [next in thread]