[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-dev
Subject:    Re: svn commit: r1096641 - /subversion/trunk/subversion/libsvn_wc/workqueue.c
From:       Greg Stein <gstein () gmail ! com>
Date:       2011-04-26 5:40:53
Message-ID: BANLkTi=NrUbw2v642wBRerQh5+0fG1WVNw () mail ! gmail ! com
[Download RAW message or body]

On Mon, Apr 25, 2011 at 20:55,  <hwright@apache.org> wrote:
>...
> +++ subversion/trunk/subversion/libsvn_wc/workqueue.c Tue Apr 26 00:55:55 2011
> @@ -525,11 +525,16 @@ run_file_commit(svn_wc__db_t *db,
>   const svn_skel_t *arg1 = work_item->children->next;
>   const char *local_relpath;
>   const char *local_abspath;
> +  apr_int64_t v;
>
>   local_relpath = apr_pstrmemdup(scratch_pool, arg1->data, arg1->len);
>   SVN_ERR(svn_wc__db_from_relpath(&local_abspath, db, wri_abspath,
>                                   local_relpath, scratch_pool, scratch_pool));
>
> +  /* We currently ignore the following two values, just kept in for compat. */
> +  SVN_ERR(svn_skel__parse_int(&v, arg1->next, scratch_pool));
> +  SVN_ERR(svn_skel__parse_int(&v, arg1->next, scratch_pool));

There's no reason to parse these things. Just some unused things
hanging off the skel... no biggy.

(and if you *were* to parse them, then the second would be arg1->next->next)

>...
> @@ -550,6 +555,10 @@ svn_wc__wq_build_file_commit(svn_skel_t
>   SVN_ERR(svn_wc__db_to_relpath(&local_relpath, db, local_abspath,
>                                 local_abspath, result_pool, scratch_pool));
>
> +  /* This are currently ignored, they are here for compat. */
> +  svn_skel__prepend_int(FALSE, *work_item, result_pool);
> +  svn_skel__prepend_int(FALSE, *work_item, result_pool);

If old code is parsing this... are the FALSE values the right values
to fill in here?

(super crazy rare case... I'm not too fussed for what the values
"should" be; this is a total edge case; just asking the Q)

Cheers,
-g

[prev in list] [next in list] [prev in thread] [next in thread]