[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-dev
Subject:    Re: [PATCH] javahl using microsecond time in LogMessage
From:       Daniel Rall <dlr () collab ! net>
Date:       2007-04-27 1:20:44
Message-ID: 20070427012044.GN28128 () collab-mlavoie ! sp ! corp ! collab ! net
[Download RAW message or body]


On Tue, 17 Apr 2007, Blair Zajac wrote:

> Mark Phippard wrote:
> >On 4/17/07, Blair Zajac <blair@orcaware.com> wrote:
> >>Well, depending upon the usage, we could be constructing a bunch of them
> >>every time the date is needed.
> >>
> >>How about setting the date field to null upon construction for the new
> >>constructor and then when it's first requested, we calculate the date
> >>and cache it.
> >>
> >>Here's a patch that does that.
> >>
> >>I realized that the part of this patch that changes everything but the
> >>LogMessage is safe to commit, so I'll probably do that shortly.  The
> >>change the LogMessage can be separate, depending upon what we decide 
> >>here.
> >
> >That is a good point.  I would go ahead with the new patch.
> 
> Committed in r24625.

I reviewed this today, looks good!

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]