[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-dev
Subject:    Re: [PATCH] Small doxygen comment fixes
From:       Karl Fogel <kfogel () google ! com>
Date:       2006-08-31 21:39:51
Message-ID: janac5k7ffc.fsf () morbius ! corp ! google ! com
[Download RAW message or body]

Marcel Gosselin <marcel.gosselin@polymtl.ca> writes:
> [[[
> Small doxygen comments fixes
>
> * subversion/include/svn_string.h
>  (svn_string_compare): Put @a flag for argument
>  (svn_cstring_split): Fix argument name
> ]]]

IMHO these fall into the "obvious fix" category:

   http://subversion.tigris.org/hacking.html#obvious-fix

In other words, no need to post a patch, just commit the fixes! :-)

-Karl

> Marcel Gosselin
> Index: subversion/include/svn_string.h
> ===================================================================
> --- subversion/include/svn_string.h	(rà ©vision 21319)
> +++ subversion/include/svn_string.h	(copie de travail)
> @@ -150,7 +150,7 @@
>  svn_string_t *svn_string_dup(const svn_string_t *original_string,
>                               apr_pool_t *pool);
>  
> -/** Return @c TRUE iff @a str1 and @c str2 have identical length and data. */
> +/** Return @c TRUE iff @a str1 and @a str2 have identical length and data. */
>  svn_boolean_t svn_string_compare(const svn_string_t *str1, 
>                                   const svn_string_t *str2);
>  
> @@ -284,7 +284,7 @@
>   * @{
>   */
>  
> -/** Divide @a input into substrings along @a sep_char boundaries, return an
> +/** Divide @a input into substrings along @a sep_chars boundaries, return an
>   * array of copies of those substrings, allocating both the array and
>   * the copies in @a pool.
>   *

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org


[prev in list] [next in list] [prev in thread] [next in thread]