[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-dev
Subject:    Re: changelists
From:       Daniel Berlin <dberlin () dberlin ! org>
Date:       2006-06-28 15:32:38
Message-ID: 44A2A116.2000106 () dberlin ! org
[Download RAW message or body]

Ben Collins-Sussman wrote:
> Thanks for looking at the changelist design doc!  Others, please join
> in and give feedback as well!
> 
> 
> On 6/28/06, Malcolm Rowe <malcolm-svn-dev@farside.org.uk> wrote:
>> On Tue, Jun 27, 2006 at 09:52:00AM -0700, sussman@tigris.org wrote:
>>> +B.  Viewing changelists
>>> +
>>> +'svn status' currently shows changelist definitions by crawling the
>>> +working copy.  Output is much more readable than perforce, because
>>> +we're still preserving column alignment:
>>> +
>>> +$ svn st
>>> +?      1.2-backports.txt
>>> +M      notes/wc-improvements
>>> +
>>> +Changelist 'status-cleanup':
>>> +M      subversion/svn/main.c
>>> +       subversion/svn/revert-cmd.c
>>> +M      subversion/svn/info-cmd.c
>>> +
>>> +Changelist 'status-printing':
>>> +M      subversion/svn/status-cmd.c
>>> +
>> Isn't this a significant change to our existing output?  Anyone who has
>> a script to look for Conflicted entries, for example, will now see the
>> changelist headers as conflicting.
>>
>> I thought we'd discussed adding a switch to show changelist membership
>> for status?
> 
> Yes, I know that at least dlr proposed it.  I haven't implemented it
> yet (though I have implemented the output above already.)  It wasn't
> clear to me that any other people wanted 'svn status' to not show
> changelists unless explicitly asked.  My personal feeling is that 'svn
> status' should *always* show changelists, and that if you're worried
> about breaking an existing output-parsing script, then just don't
> create changelists in the first place!

I agree completely on both parts, though i do like the idea of just
putting an unused char there instead.

I think the idea of not showing changelists by default is, well,
ridiculous and unintuitive, TBQH.

--Dan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

[prev in list] [next in list] [prev in thread] [next in thread]