[prev in list] [next in list] [prev in thread] [next in thread]
List: subversion-dev
Subject: RE: [PATCH] ver2: remove progname hardcoding in svnmerge,py
From: "Madan U S" <madan () collab ! net>
Date: 2006-03-31 13:48:21
Message-ID: 2B1318F17141D34BBCBC42F34DAAECD1E5E79C () maa-exch ! maa ! corp ! collab ! net
[Download RAW message or body]
On Friday 31 Mar 2006 7:00 pm, Malcolm Rowe wrote:
> On Fri, Mar 31, 2006 at 06:40:44PM +0530, Madan U S wrote:
> > [[[
> > Remove hard-coding of program name
>
> Why bother? We don't do this for any of the other executables.
Its good practise. Am guessing we dont do it for the *other* =
executables, because of the complexity, and the multiple source files =
which need this info (I mean, this data has to be passed on from the =
main to all other error handling functions).
But here, its just one single python script. It makes more sense to use =
argv than not to.
> Could you also try to send your patches with a Content-Type other than
> application/octet-stream, since that makes them harder to read than
> is necessary?
oops, sorry. Didnt realize the attachments were octet-stream.
Regards,
Madan.
[Attachment #3 (text/html)]
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-1">
<META NAME="Generator" CONTENT="MS Exchange Server version 6.5.7638.1">
<TITLE>RE: [PATCH] ver2: remove progname hardcoding in svnmerge,py</TITLE>
</HEAD>
<BODY>
<!-- Converted from text/plain format -->
<P><FONT SIZE=2>On Friday 31 Mar 2006 7:00 pm, Malcolm Rowe wrote:<BR>
> On Fri, Mar 31, 2006 at 06:40:44PM +0530, Madan U S wrote:<BR>
> > [[[<BR>
> > Remove hard-coding of program name<BR>
><BR>
> Why bother? We don't do this for any of the other executables.<BR>
<BR>
Its good practise. Am guessing we dont do it for the *other* executables, because of \
the complexity, and the multiple source files which need this info (I mean, this data \
has to be passed on from the main to all other error handling functions).<BR> <BR>
But here, its just one single python script. It makes more sense to use argv than not \
to.<BR> <BR>
> Could you also try to send your patches with a Content-Type other than<BR>
> application/octet-stream, since that makes them harder to read than<BR>
> is necessary?<BR>
<BR>
oops, sorry. Didnt realize the attachments were octet-stream.<BR>
<BR>
Regards,<BR>
Madan.</FONT>
</P>
</BODY>
</HTML>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic