[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-dev
Subject:    Re: svn commit: r17572 - in trunk/subversion: libsvn_ra_dav libsvn_repos libsvn_subr
From:       Erik Huelsmann <ehuels () gmail ! com>
Date:       2005-11-30 23:09:46
Message-ID: aea328ab0511301509h30704acdq3bae7596262a5dee () mail ! gmail ! com
[Download RAW message or body]

On 12/1/05, Greg Hudson <ghudson@mit.edu> wrote:> On Wed, 2005-11-30 at 17:48 -0600, \
dionisos@tigris.org wrote:> >   Create a subpool to allocate SVN_STREAM_CHUNK_SIZE \
buffers.  Just before> >   completing successfully, clean the subpool to free the \
100kB buffer.>> I don't understand the need for this.  If the function is being \
called> in a loop, the loop should be using an iteration pool.  If the function> is \
not being called from a loop, 100K is noise. This commit is a consequence of lundblad \
'complaining' about the factthat I left a buffer allocated in libsvn_subr/subst.c. \
That buffer wasabout the same size. So, I looked where else the buffer was \
allocatedand disposed of, moving the allocation to a subpool if it wasn'talready.
> If the functions return allocated information, that might make it worth> doing \
> large temporary allocations in a subpool.  You didn't include any> symbol names in \
> your log message, so I can't easily tell whether you> modified functions of that \
> nature.
No, I didn't modify any of those.
bye,
Erik.


[prev in list] [next in list] [prev in thread] [next in thread]