[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-dev
Subject:    Re: [PATCH] Resolve issue 2426: Reverting relative to working copy root (sometimes) fails
From:       Ivan Zhakov <chemodax () gmail ! com>
Date:       2005-10-29 17:33:22
Message-ID: 937880ca0510291033l17da7573m5c67a542c2d609bc () mail ! gmail ! com
[Download RAW message or body]

On 10/29/05, Erik Huelsmann <ehuels@gmail.com> wrote:> Now with patch...>> On \
10/29/05, Erik Huelsmann <ehuels@gmail.com> wrote:> > This patch fixes issue 2426, \
which is a wc-replacements regression.> >> > I think it could use some review before \
I commit this though, so, if you please.> >> > Effectively, this patch makes it \
possible to create relative prop-file> > paths without path calculation outside of \
props.c.  Currently path> > calculations do take place to insert relative prop paths \
into log> > files.Hi Erik,There is some small nits and one big problem: \
svn_wc_entry() mayreturn *entry=NULL without raising error. So it should be checked. \
Ifound inserting patch inline uncomfortable, so I comment without it.
> > Log:> > [[[> > Fix issue #2426: revert_tests.py test 1 fails.> >> > * \
> > subversion/libsvn_wc/adm_files.h> > * subversion/libsvn_wc/adm_files.c> >   \
> > (svn_wc__wcprop_path, svn_wc__prop_path, svn_wc__prop_base_path,> >    \
> > svn_wc__prop_revert_path): Change function signature to take an explicitly> >   \
> > specified node kind, indicating which property file we want, instead of> >   \
> > deducing that from path and adm_access.Comment and docstring should say that we \
> > accept only svn_node_dir andsvn_node_file as value for kind parameter. Also I \
> >                 have noticed thatvariable 'entry' become unused.
> > * subversion/libsvn_wc/props.c(open_reject_tmp_file, \
> >                 wcprop_list,svn_wc__has_props,svn_wc_get_prop_diffs): No check \
> >                 for entry==NULL.
> > * subversion/libsvn_wc/diff.cChange in load_base_props() need more documentation. \
> >                 I don'tunderstand this change.
> > * subversion/libsvn_wc/copy.cIn function copy_file_administratively() variable \
> >                 'dst_wprop'initialized, but unused.
> > * subversion/libsvn_wc/adm_crawler.c> > * \
> > subversion/libsvn_wc/log.c(log_do_modify_entry)No check for tfile_entry==NULL. I \
> >                 know this impossible, but anywaythis check should be for me.
> > * subversion/libsvn_wc/adm_ops.c> > * \
> >                 subversion/libsvn_wc/update_editor.c(install_file): Unused \
> >                 variable 'entry'.
> > * subversion/libsvn_wc/questions.c:> >   Adjust callers.> >> >> > ]]]

--Ivan Zhakov


[prev in list] [next in list] [prev in thread] [next in thread]