[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-dev
Subject:    Re: [PATCH] Re: "Revision" case-sensitive in svn:keywords
From:       Wesley J Landaker <wjl () icecavern ! net>
Date:       2005-01-28 19:17:51
Message-ID: 200501281218.07150.wjl () icecavern ! net
[Download RAW message or body]


On Friday, 28 January 2005 12:07, John Peacock wrote:
> Wesley J. Landaker wrote:
> > On Thu, 27 Jan 2005, Felix Wiemann wrote:
> >>The word "revision" is not recognized in svn:keywords, but
> >> "Revision" is.  IMO it should be matched case-insensitively for
> >> consistency with 'Author' or 'Date', shouldn't it?
> >
> > This seems like a good idea, since all the other "SHORT" forms are
> > handled thus (and this is the only "MEDIUM" one). Here is a patch
> > if the developer's agree as well. =)
>
> The problem is that $Revision$ is an equivalent keyword to the same
> one in CVS, and it _is_ case-sensitive there.  I don't know if
> changing it to be case-insensitive is the appropriate thing to; the
> short forms are unique to Subversion, so that's not such a big deal.

Well, I always use them cased exactly myself, so I really don't mind 
either way, I just thought I'd be helpful. ;) 

I just wasn't sure if having "Rev" be case insensitive, but not 
"Revision" was on purpose, or an oversight, since the trend seemed to 
be along the lines of "long keywords are case sensitive, short ones are 
not". 

> It will also very slightly complicate my keywords-as-hash patch,
> since I would have to normalize the capitalization of the hash keys
> (not a big deal really).

I actually think it's cleaner to have *all* of the keyword forms be 
case-sensitive, but that breaks backwards-compatibility . . . =(

-- 
Wesley J. Landaker <wjl@icecavern.net>
OpenPGP FP: 4135 2A3B 4726 ACC5 9094  0097 F0A9 8A4C 4CD6 E3D2


[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]