[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-dev
Subject:    Re: [PATCH] Put CPPFLAGS in SWIG_PY_COMPILE and friends
From:       Sander Roobol <phy () wanadoo ! nl>
Date:       2003-08-31 14:16:16
[Download RAW message or body]

On Sat, Aug 16, 2003 at 02:17:05PM -0500, Eric Gillespie wrote:
> Greg Hudson <ghudson@MIT.EDU> writes:
> 
> > Well, it's better to perpetuate existing hackishness than it is to
> > introduce completely new hackishness, but it's still distasteful.  When
> > you have a variable substituted into a Makefile by a configure script,
> > it shouldn't change name or value during the assignment, or people are
> > more likely to get confused when debugging build problems.  Better to
> > pick different variable names for the extended values.
> 
> OK.  How's this?  SWIG_PY_COMPILE and SWIG_PL_COMPILE are only
> used to define COMPILE_PY_WRAPPER and COMPILE_PL_WRAPPER, so it
> looks like the extended value macro you were suggesting already
> exists.

I've filed this patch as issue #1503:
  http://subversion.tigris.org/issues/show_bug.cgi?id=1503

Sander

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

[prev in list] [next in list] [prev in thread] [next in thread]