[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-dev
Subject:    Re: [PATCH] Re: Code cleanup: Harmonized tests (Take 2)
From:       Erik =?ISO-8859-1?Q?H=FClsmann?= <e.huelsmann () gmx ! net>
Date:       2003-08-30 18:28:54
[Download RAW message or body]

Ok, found out my error with the commit_tests.py test 15. No problem anymore. I \
decided not to post the patch until someone says to go ahead: I didn't expect the \
mail to become 222kB.

bye,

Erik.


> Sorry, meant to send the message below to the list too. Was accedentally only sent \
> to cmpilato and Fitz 
> bye,
> 
> 
> Erik
> 
> 
> ------- Original message -------
> Hi!
> 
> 
> Ok, I sat down and started rewriting svntest.main.svn_run to \
> svntest.actions.run_and_verify_svn calls. I left alone those instances where the \
> context does not do any output-checks. 
> The code is not completely finished: there is one tests which keeps failing. I have \
> not been able to find out why yet:  
> XPASS: commit_tests.py 15: hook testing
> 
> Looking at the code I don't understand why commit_tests.py 15 should be marked \
> XFail. 
> I thought I could submit this before the final state of the patch, because it would \
> take quite some time to review it anyway. And I would have some time to fix \
> commit_tests 15 before the patch is accepted anyway. 
> One last remark cmpilato wrote he would have liked to have the space changes as a \
> separate patch. I decided that if you all don't mind too much, I could make a \
> separate patch doing the rest of the space changes, but leaving the current patch \
> as-is. Since it would take so much time to undo the space-change stuff... 
> BTW: the patch statistics have become a bit more aggressive than they were:
> Total number of lines:   6100
> Number of lines added:   1236
> Number of lines removed: 1819
> 
> 
> Let me know what you think.
> 
> 
> bye,
> 
> Erik.
> 
> 
> Log:
> [[[
> Rewrite the test suite to new philosophy where
> exceptions are raised to pass errors back to
> the caller.
> 
> * subversion/tests/clients/cmdline/basic_tests.py
> * subversion/tests/clients/cmdline/commit_tests.py
> * subversion/tests/clients/cmdline/copy_tests.py
> * subversion/tests/clients/cmdline/diff_tests.py
> * subversion/tests/clients/cmdline/export_tests.py
> * subversion/tests/clients/cmdline/externals_tests.py
> * subversion/tests/clients/cmdline/log_tests.py
> * subversion/tests/clients/cmdline/merge_tests.py
> * subversion/tests/clients/cmdline/prop_tests.py
> * subversion/tests/clients/cmdline/schedule_tests.py
> * subversion/tests/clients/cmdline/stat_tests.py
> * subversion/tests/clients/cmdline/svnadmin_tests.py
> * subversion/tests/clients/cmdline/svnlook_tests.py
> * subversion/tests/clients/cmdline/trans_tests.py
> * subversion/tests/clients/cmdline/update_tests.py
> * subversion/tests/clients/cmdline/utf8_tests.py
> 
> 
> ]]]
> 
> 
> > > "B. W. Fitzpatrick" <fitz@red-bean.com> writes:
> > > 
> > > > > > Last week I submitted a little change to the svnversion test. Before
> > > > > > the test was found acceptable, I had to rewrite it so that it was
> > > > > > written as a 'new style' test: one which uses the Python exception
> > > > > > handling instead of the return 0 / return 1 structure.
> > > > > 
> > > > > I'm reviewing this now.
> > > > 
> > > > I have a few comments about the patch:
> > > > 
> > > > 1. Yay!
> > > > 
> > > > 2. I'd like to see the whitespace changes in a separate patch, but
> > > > that's not really A Big Deal.
> > > > 
> > > > 3. I found a couple of places where you're doing this:
> > > > 
> > > > stat_output, err_output = svntest.main.run_svn(None, 'stat', '-vN')
> > > > if err_output:
> > > > raise svntest.Failure       
> > > > 
> > > > I'd like to see you use
> > > > 
> > > > run_and_verify_svn(message, expected_stdout, expected_stderr, *varargs):
> > > > 
> > > > in these cases.  It integrates the checking for different outputs on
> > > > stderr and stdout.  I've already converted a bunch of the tests to use
> > > > it, so there are plenty of examples.
> > > 
> > > These fixes, plus addressing the "raise 1" oopsy, plus my sudden lack
> > > of immediate time to review and apply the patch are good reasons to
> > > suggest that the patch be resubmitted with the proper fixes in place.
> > > At that later date, perhaps I'll have more review/application time to
> > > offer.
> > 
> > OK.  Erik, if you want to make those changes and resubmit, I'll do my
> > best to review ASAP, but I can't guarantee anything this week cause
> > I'm swamperoonied.
> > 
> > -Fitz
> > 
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org


[prev in list] [next in list] [prev in thread] [next in thread]