[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-dev
Subject:    Re: svn diff segfault
From:       Vladimir Prus <ghost () cs ! msu ! su>
Date:       2002-01-23 15:28:29
[Download RAW message or body]

cmpilato@collab.net wrote:

> Well, I was about to freak out reading this portion of the patch until
> I saw you comment here.  Whew!  So, you've hit on something that has
> been bothering me for some time about our Python tests -- we don't
> detect segfaults.  How hard would it be to adjust svntest.main.run_svn()
> so that it *could* return an error if a segfault occured (perhaps a -1
> instead of a 1, something) ?  My feeling is that the Right Way to do
> this is to first fix the broken run_svn() function, then use it.  That
> way you essentially get credit for fixing the entire Python test suite,
> and we don't have to revisit this again. :-)

I don't think we can do it in a completely portable fashion. AFAIK, 
os.popen2/os.popen3 give no way to find program's return status, and the 
Popen3 class is not available on windows. Would it be ok to use Popen3 on 
Unix, and retain the current behaviour on win?

- Volodya

[prev in list] [next in list] [prev in thread] [next in thread]