[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-dev
Subject:    RE:  Re: [PATCH] Trace update, and cancel update editors patch
From:       "Bill Tutt" <billtut () microsoft ! com>
Date:       2001-12-24 21:54:13
[Download RAW message or body]


> From: Greg Stein [mailto:gstein@lyra.org]
 
> >...
> > +/* Used by the trace_update editor in libsvn_client
> > + */
> > +void
> > +svn_cl__print_message(void *ui_baton,
> > +                      svn_stringbuf_t *msg)
> > +{
> > +  fputs(msg->data, stdout);
> > +}
> 
> 1) that should be const svn_string_t *, or just const char *. No need
for
> a
>    darned stringbuf.
> 
> 2) use fwrite if you have a string(buf), since you already have the
length.
> 

Most (99.9%) of the trace messages are formatted output anyway. If we
pass in a stringbuf, the extra length data might help out UI apps that
need to convert the thing into a Unicode string. Additionally, the
command line client is going to use puts() anyway, since the trace
messages shouldn't include \n at the end of the strings.

Bill

[prev in list] [next in list] [prev in thread] [next in thread]