[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-cvs
Subject:    svn commit: r32330 - trunk/subversion/libsvn_subr
From:       hwright () tigris ! org
Date:       2008-07-29 22:26:45
Message-ID: 200807292226.m6TMQjjO020359 () svn2 ! sjc ! collab ! net
[Download RAW message or body]

Author: hwright
Date: Tue Jul 29 15:26:45 2008
New Revision: 32330

Log:
Followup r32328: Add a runtime assert for invalid input.

r32328 removed a potential crash from a NULL pointer reference.  However, stsp
points out that the crash actually was a form of input validation.  This patch
uses the new SVN_ERR_ASSERT() macro to do input validation the Right Way.

Suggested by: stsp

* subversion/libsvn_subs/simple_providers.c
  (svn_auth__simple_save_creds_helper): Make sure that passtype is not NULL.

Modified:
   trunk/subversion/libsvn_subr/simple_providers.c

Modified: trunk/subversion/libsvn_subr/simple_providers.c
URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_subr/simple_providers.c?pathrev=32330&r1=32329&r2=32330
 ==============================================================================
--- trunk/subversion/libsvn_subr/simple_providers.c	Tue Jul 29 13:40:30 2008	(r32329)
+++ trunk/subversion/libsvn_subr/simple_providers.c	Tue Jul 29 15:26:45 2008	(r32330)
@@ -237,6 +237,9 @@ svn_auth__simple_save_creds_helper(svn_b
                                          SVN_AUTH_PARAM_NO_AUTH_CACHE,
                                          APR_HASH_KEY_STRING) != NULL);
 
+  /* Make sure we've been passed a passtype. */
+  SVN_ERR_ASSERT(passtype != NULL);
+
   *saved = FALSE;
 
   if (no_auth_cache)

---------------------------------------------------------------------
To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
For additional commands, e-mail: svn-help@subversion.tigris.org


[prev in list] [next in list] [prev in thread] [next in thread]