[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-cvs
Subject:    svn commit: r8863 - trunk/subversion/libsvn_client
From:       rooneg () tigris ! org
Date:       2004-02-28 23:17:42
Message-ID: 200402282317.i1SNHgs02194 () svn ! collab ! net
[Download RAW message or body]

Author: rooneg
Date: Sat Feb 28 17:17:41 2004
New Revision: 8863

Modified:
   trunk/subversion/libsvn_client/copy.c
Log:
fix a crash that occurs when a directory that was scheduled for deletion 
is manually deleted by the user, then you try to copy over it.

* subversion/libsvn_client/copy.c
  (setup_copy): don't pass a NULL url on to the rest of the copy code, 
  instead error out with SVN_ERR_ENTRY_MISSING_URL.  the NULL url will 
  just cause a crash later on, so returning an error seems safest.


Modified: trunk/subversion/libsvn_client/copy.c
==============================================================================
--- trunk/subversion/libsvn_client/copy.c	(original)
+++ trunk/subversion/libsvn_client/copy.c	Sat Feb 28 17:17:41 2004
@@ -1051,6 +1051,12 @@
                   (SVN_ERR_UNVERSIONED_RESOURCE, NULL,
                    "'%s' is not under version control", src_path);
 
+              if (! entry->url)
+                return svn_error_createf
+                  (SVN_ERR_ENTRY_MISSING_URL, NULL,
+                   "'%s' does not seem to have a URL associated with it",
+                   src_path);
+
               src_path = entry->url;
               src_is_url = TRUE;
             }

---------------------------------------------------------------------
To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
For additional commands, e-mail: svn-help@subversion.tigris.org

[prev in list] [next in list] [prev in thread] [next in thread]