[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-commits
Subject:    svn commit: r1889133 - /subversion/trunk/subversion/tests/svn_test_main.c
From:       danielsh () apache ! org
Date:       2021-04-23 17:50:12
Message-ID: 20210423175012.48CDC17B4D9 () svn01-us-east ! apache ! org
[Download RAW message or body]

Author: danielsh
Date: Fri Apr 23 17:50:11 2021
New Revision: 1889133

URL: http://svn.apache.org/viewvc?rev=1889133&view=rev
Log:
* subversion/tests/svn_test_main.c
  (svn_test_main): Add a safety net ensuring APR_HAS_THREADS-less builds
    would fail, rather than pass silently, if they tried to take the
    "Run tests concurrently" codepath (which try would be a bug).

Review by: hartmannathan

Modified:
    subversion/trunk/subversion/tests/svn_test_main.c

Modified: subversion/trunk/subversion/tests/svn_test_main.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/svn_test_main.c?rev=1889133&r1=1889132&r2=1889133&view=diff
 ==============================================================================
--- subversion/trunk/subversion/tests/svn_test_main.c (original)
+++ subversion/trunk/subversion/tests/svn_test_main.c Fri Apr 23 17:50:11 2021
@@ -1089,9 +1089,9 @@ svn_test_main(int argc, const char *argv
               svn_pool_clear(cleanup_pool);
             }
         }
-#if APR_HAS_THREADS
       else
         {
+#if APR_HAS_THREADS
           got_error = do_tests_concurrently(opts.prog_name, test_funcs,
                                             array_size, max_threads,
                                             &opts, test_pool);
@@ -1099,8 +1099,11 @@ svn_test_main(int argc, const char *argv
           /* Execute all cleanups */
           svn_pool_clear(test_pool);
           svn_pool_clear(cleanup_pool);
-        }
+#else
+          /* Can't happen */
+          SVN_ERR_MALFUNCTION();
 #endif
+        }
     }
 
   /* Clean up APR */


[prev in list] [next in list] [prev in thread] [next in thread]