[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-commits
Subject:    svn commit: r1791283 - /subversion/trunk/subversion/libsvn_ra_serf/update.c
From:       kotkov () apache ! org
Date:       2017-04-13 17:20:44
Message-ID: 20170413172045.3E5603A0912 () svn01-us-west ! apache ! org
[Download RAW message or body]

Author: kotkov
Date: Thu Apr 13 17:20:44 2017
New Revision: 1791283

URL: http://svn.apache.org/viewvc?rev=1791283&view=rev
Log:
ra_serf: Properly advertise gzip support for GET requests with delta
base, in addition to saying that we accept svndiff1 and svndiff0.

There is no need to hide gzip support if the client is interested in
compression.  And it also allows a server to choose between various ways
of sending compressed deltas, which could either be compressed with
svndiff1, or a delta itself could be uncompressed, but the whole
response could be, for instance, compressed with mod_deflate.

* subversion/libsvn_ra_serf/update.c
  (headers_fetch): Use svn_ra_serf__setup_svndiff_accept_encoding()
   helper to advertise gzip, svndiff1 and svndiff0 support.

Modified:
    subversion/trunk/subversion/libsvn_ra_serf/update.c

Modified: subversion/trunk/subversion/libsvn_ra_serf/update.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/update.c?rev=1791283&r1=1791282&r2=1791283&view=diff
 ==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/update.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/update.c Thu Apr 13 17:20:44 2017
@@ -797,17 +797,8 @@ headers_fetch(serf_bucket_t *headers,
     {
       serf_bucket_headers_setn(headers, SVN_DAV_DELTA_BASE_HEADER,
                                fetch_ctx->delta_base);
-      if (fetch_ctx->using_compression)
-        {
-          serf_bucket_headers_setn(headers, "Accept-Encoding",
-                                   "svndiff1;q=0.9,svndiff;q=0.8");
-        }
-      else
-        {
-          /* Do not advertise svndiff1 support if we're not interested in
-             compression. */
-          serf_bucket_headers_setn(headers, "Accept-Encoding", "svndiff");
-        }
+      svn_ra_serf__setup_svndiff_accept_encoding(headers,
+                                                 fetch_ctx->using_compression);
     }
   else if (fetch_ctx->using_compression)
     {


[prev in list] [next in list] [prev in thread] [next in thread]