[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-commits
Subject:    RE: svn commit: r1403979 - /subversion/trunk/subversion/libsvn_subr/io.c
From:       "Bert Huijben" <bert () qqmail ! nl>
Date:       2012-10-31 9:33:35
Message-ID: 016b01cdb74a$d07f50c0$717df240$ () qqmail ! nl
[Download RAW message or body]



> -----Original Message-----
> From: danielsh@apache.org [mailto:danielsh@apache.org]
> Sent: woensdag 31 oktober 2012 05:50
> To: commits@subversion.apache.org
> Subject: svn commit: r1403979 -
> /subversion/trunk/subversion/libsvn_subr/io.c
> 
> Author: danielsh
> Date: Wed Oct 31 04:50:22 2012
> New Revision: 1403979
> 
> URL: http://svn.apache.org/viewvc?rev=1403979&view=rev
> Log:
> No functional change.
> 
> * subversion/libsvn_subr/io.c
>   (do_io_file_wrapper_cleanup): Move earlier in the file so that it's next
>     to a "Forward declarations" header.
> 
> Modified:
>     subversion/trunk/subversion/libsvn_subr/io.c
> 
> Modified: subversion/trunk/subversion/libsvn_subr/io.c
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/io.
> c?rev=1403979&r1=1403978&r2=1403979&view=diff
> ==========================================================
> ====================
> --- subversion/trunk/subversion/libsvn_subr/io.c (original)
> +++ subversion/trunk/subversion/libsvn_subr/io.c Wed Oct 31 04:50:22 2012
> @@ -2077,11 +2077,6 @@ svn_io_file_lock2(const char *lock_file,
>  

>  /* Data consistency/coherency operations. */
> 
> -static APR_INLINE svn_error_t *
> -do_io_file_wrapper_cleanup(apr_file_t *file, apr_status_t status,
> -                           const char *msg, const char *msg_no_name,
> -                           apr_pool_t *pool);
> -
>  svn_error_t *svn_io_file_flush_to_disk(apr_file_t *file,
>                                         apr_pool_t *pool)
>  {
> @@ -3726,6 +3721,10 @@ svn_io_dir_open(apr_dir_t **new_dir, con
>  /* Forward declaration */
>  static apr_status_t
>  dir_is_empty(const char *dir, apr_pool_t *pool);
> +static APR_INLINE svn_error_t *
> +do_io_file_wrapper_cleanup(apr_file_t *file, apr_status_t status,
> +                           const char *msg, const char *msg_no_name,
> +                           apr_pool_t *pool);

Just looking at this patch, isn't this moving it to further in the file?
(Or is it just switching the order and do we see a different diff?)

The log message would indicate that you moved the definition up.

	Bert 



[prev in list] [next in list] [prev in thread] [next in thread]